Overview

Features:

1. New plugin type: "Grade penalty"
2. A "Grade penalty" plugin: "Late submission penalty", which define rules to calculate penalty (based on submission date and due date )
3. A new grade API function: apply_grade_penalty_to_user, which will be used by supported module to apply penalty over original grade
4. Grade penalty implementation in assignment module
5. Allow user to trigger penalty recalculation
6. Show penalty indicator in user and grader report
7. Option to apply penalty to overridden grade, providing the penalty was applied to original grade.

Settings

Enable "Late submission penalty" plugin

1. Go to "Grades > Grade penalties > Manage penalty plugins* in site administration:
   • Click on 'toggle' button to enable 'Late submission penalties' plugin
2. Go to "Grades > Grade penalties > Late submission penalties > Penalty rules":
   • Create some penalty rules

Enable "Grade penalty" for assignment

1. Go to "Grades > Grade penalties > Supported modules":
   • Click to select "Assignment"
   • Save changes

Enable "Apply penalty to overridden grades"

1. Go to "Grades > Grade penalties > Supported modules":
   • Enable "Apply penalty to overridden grades"
   • Save changes

Testing: Penalty implementation on an assignment

1. Create a test course
2. Create an assignment in the course:
   1. Set due date to "Yesterday" / a date in the past
   2. Submission types: File submissions
   3. Make sure grade type is set to point
   4. Enable "Grade penalties" under "Grade" section
3. Enrol a student to the course
4. Login as the student
5. Add an submission
6. Log in as an teacher to mark the submission
   1. Expected behavior: The grade in grade book is deducted according to the penalty rules
   2. In the submission list: the grade is original assignment grade (without penalty), the final grade (gradebook grade) is the one with penalty

Testing: Penalty recalculation

1. Go to the assignment created on previous test
2. Go to "Grade penalties" on Assignment navigation bar
3. Change penalty rules
4. Then click on "Recalculate penalties" button
5. Wait or run cron job so that "recalculate_penalties" adhoc task can be run:
   1. Expected: the adhoc task "recalculate_penalties" should run
   2. The final grade of the student should be recalculated according to the new rules

Testing: Penalty indicator

1. Go to the test course
2. Make sure the course is on "Non editing"
3. Go to "Grade > Grader report". Expected:
   1. There is a red triangle icon, with a tooltip showing the penalty
4. Go to "Grade > User report".
5. Select the testing user. Expected:
   1. There is a red triangle icon, with a tooltip showing the penalty

Testing: Apply penalty to overridden mark

1. Go to the test course
2. Go to "Grade > Grader report"
3. Turn on "Editing mode"
4. Change "Original grade" for the testing assignment grade item
5. Make sure the "Exempt penalty" is not checked
6. Save changes. Expected:
   1. The "Current grade" is subtracted with the same penalized amount
7. Turn off "Editing mode". Expected:
   1. The grade is same as "Current grade" and showing penalty indicator
8. Turn on "Editing mode" again
9. Tick "Exempt penalty" checkbox
10. Save changes. Expected:
    1. The "Current grade" is the same as "Original grade"
11. Turn off "Editing mode". Expected:
    1. The grade is same as "Current grade" and there is no penalty indicator

Testing: No penalty is applied to imported grade

Testing the notification

1. Enable a penalty plugin.
   • /grade/penalty/manage_penalty_plugins.php
2. Navigate to a course.
3. Navigate to Grades > Import.
4. Verify the notification is displayed on the various import pages.
5. Disable all penalty plugins.
6. Verify the notification no longer appears.

   Testing Import

• Create a course with an assignment.
• Enrol some students and give them a grade.
• Grade export will include the raw mark and final mark. The final mark includes any penalties.
• Navigate to the course > Grades > Export.
• Export the grades for the assignment.
  • Export as > Plain text file.
• Delete the recent grades from the mdl_grade_grades table.
• Verify the grades are gone (Grades > Grader report and/or assignment > Submissions).
• Set the assignment due date to some point in the past and configure penalty rules if not already done.
• Import the grades.
  • Map from > Email address.
  • Map to > Email address.
  • [assignment] (Real) > Grade items > [assignment]
• Verify the grades have been restored, and no additional penalties have been applied.

Fails against automated checks.

Checked MDL-80984 using repository: https://github.com/catalyst/moodle

• main (3 errors / 0 warnings) [branch: MDL-80984-main | CI Job]
  • overview (0/0), phplint (0/0), phpcs (3/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Wed Mar 19 06:30:27 UTC 2025

Launching automatic jobs for branch MDL-80984-main

• https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18662/ PHPUnit (sqlsrv / complete)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63930/ Behat (NonJS - boost and classic / complete)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63931/ Behat (Firefox - boost / complete)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63932/ Behat (Firefox - classic / complete)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63933/ App tests (stable app version) / complete)

Built on: Wed Mar 19 07:07:05 UTC 2025