-
Bug
-
Resolution: Fixed
-
Low
-
None
While reviewing MDL-48620 for integration i detected that, while shifter was returning no problems (but the rangy one), the jshint execution, at the same time, was returning a bunch of errors (undefined vars...).
See https://tracker.moodle.org/browse/MDL-48620?focusedCommentId=335713&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-335713 for the comments and discussion about that.
So that leaded me to create this issue, because I bet we are going to stat producing "false" jshint reports in many situations.
Not sure if the solution is to switch to shifter, that controls the whole codebase when combining the files, or we must move onto a 2-step way, or perhaps relax checks... or what.
But it really looks like we need some action here.
Ciao
- blocks
-
MDL-54889 Stop using jshint for everything but shifter
-
- Closed
-
- is blocked by
-
MDLSITE-4419 Move current nodejs/npm stuff in local_ci to universal npm installer
-
- Closed
-
- will be (partly) resolved by
-
MDL-52127 Check Moodle JS coding style with eslint
-
- Closed
-