Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48620

.jshintrc does not comply with coding style

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.9
    • 2.7.3, 2.8.1
    • JavaScript
    • FRONTEND Sprint 16, Team B Sprint 1, Team Beards Sprint 2
    • Medium

      I thought I'd created an issue for this but can't for the life of me find it so apparently I just discussed it.

      The current .jshintrc does not comply with the JS + Generic coding style. This need to be fixed.

      http://jshint.com/docs/options/
      https://docs.moodle.org/dev/Javascript/Coding_style

      The ones I know about are:

      1. eqeqeq (=== vs ==)
      2. maxlen (was set to 180, but we now use 132)
      3. indent (should be set to 4)
      4. undef (warn about variables used before they are declared)

      In addition, several options we were using have been deprecated from jshint (https://github.com/jshint/jshint/releases/tag/2.5.0):

      1. onevar - fine by use as was set to false
      2. nomen
      3. passfail
      4. white
      5. gcl
      6. smarttabs
      7. trailing

      In addition, the `indent` option is now not a warning.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Zachary Durber Zachary Durber
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.