-
Bug
-
Resolution: Fixed
-
Minor
-
2.7.3, 2.8.1
-
MOODLE_27_STABLE, MOODLE_28_STABLE
-
MOODLE_29_STABLE
-
MDL-48620-master -
-
FRONTEND Sprint 16, Team B Sprint 1, Team Beards Sprint 2
-
Medium
I thought I'd created an issue for this but can't for the life of me find it so apparently I just discussed it.
The current .jshintrc does not comply with the JS + Generic coding style. This need to be fixed.
http://jshint.com/docs/options/
https://docs.moodle.org/dev/Javascript/Coding_style
The ones I know about are:
- eqeqeq (=== vs ==)
- maxlen (was set to 180, but we now use 132)
- indent (should be set to 4)
- undef (warn about variables used before they are declared)
In addition, several options we were using have been deprecated from jshint (https://github.com/jshint/jshint/releases/tag/2.5.0):
- onevar - fine by use as was set to false
- nomen
- passfail
- white
- gcl
- smarttabs
- trailing
In addition, the `indent` option is now not a warning.