Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43997

Dialogues no longer show automatically, or modally

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • JavaScript
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-43997-master
    • Hide
      • Open a course
      • Click 'Backup'
      • Click on the Cancel button
        • Confirm that the dialogue is centred
        • Confirm that the dialogue is modal and has a lightbox
      • Edit lib/ajax/getsiteadminbranch.php
      • echo some content out after ajax_capture_output();
      • Refresh any page
      • Expand the Site administration
        • Confirm that an error was displayed centred, and modal
      • Change your echo to:

        throw new moodle_exception('banana');
        

      • Refresh any page
      • Expand the Site administration
        • Confirm that an error was displayed centred, and modal
      • Open your JS console and enter:

        Y.use('moodle-core-notification');
        

      • Confirm that each of the following displays a dialogue immediately, centred, and modal (with lightbox
        • ajaxException:

          foo = new M.core.ajaxException({});
          

        • alert

          foo.destroy();
          foo = new M.core.alert({});
          

        • confirm

          foo.destroy();
          foo = new M.core.confirm({});
          

        • exception

          foo.destroy();
          foo = new M.core.exception({});
          

      • Confirm that the following does not display a new dialogue

        foo.destroy();
        foo = new M.core.dialogue({});
        

      • Now open it and confirm that it is:
        • centred
        • not modal (has no lightbox)

          foo.show();
          

      Show
      Open a course Click 'Backup' Click on the Cancel button Confirm that the dialogue is centred Confirm that the dialogue is modal and has a lightbox Edit lib/ajax/getsiteadminbranch.php echo some content out after ajax_capture_output(); Refresh any page Expand the Site administration Confirm that an error was displayed centred, and modal Change your echo to: throw new moodle_exception('banana'); Refresh any page Expand the Site administration Confirm that an error was displayed centred, and modal Open your JS console and enter: Y.use('moodle-core-notification'); Confirm that each of the following displays a dialogue immediately, centred, and modal (with lightbox ajaxException: foo = new M.core.ajaxException({}); alert foo.destroy(); foo = new M.core.alert({}); confirm foo.destroy(); foo = new M.core.confirm({}); exception foo.destroy(); foo = new M.core.exception({}); Confirm that the following does not display a new dialogue foo.destroy(); foo = new M.core.dialogue({}); Now open it and confirm that it is: centred not modal (has no lightbox) foo.show();
    • 8

      Since MDL-43262 and MDL-43259 landed in master, we no longer show some types of dialogue automatically or modally.

        1. bug1.png
          965 kB
          Jérôme Mouneyrac

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Petr Skoda Petr Skoda
            Sam Hemelryk Sam Hemelryk
            Jérôme Mouneyrac Jérôme Mouneyrac
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.