Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44085

Replace JS native confirm for a YUI confirm

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • JavaScript
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-44085_master
    • Hide
      1. Open JS console to ensure there are no JS errors
      2. Go to a course, click on an activity actions menu and click on delete
      3. The JS confirm dialogue SHOULD be replaced by a YUI modal window
      4. Click 'No', you SHOULD return to the course main page and the activity SHOULD NOT be deleted
      5. Click on another activity actions menu -> delete
      6. Now click 'Yes' (in the YUI modal window)
      7. The 2nd activity SHOULD be deleted
      8. The 1st activity SHOULD NOT be deleted
      Show
      Open JS console to ensure there are no JS errors Go to a course, click on an activity actions menu and click on delete The JS confirm dialogue SHOULD be replaced by a YUI modal window Click 'No', you SHOULD return to the course main page and the activity SHOULD NOT be deleted Click on another activity actions menu -> delete Now click 'Yes' (in the YUI modal window) The 2nd activity SHOULD be deleted The 1st activity SHOULD NOT be deleted

      The native JS confirm() blocks the whole browser and it is working in an OS scope, we could replace it for a YUI modal window as commented https://tracker.moodle.org/browse/MDL-43802?focusedCommentId=270267&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-270267

            dmonllao David Monllaó
            dmonllao David Monllaó
            Andrew Lyons Andrew Lyons
            Sam Hemelryk Sam Hemelryk
            Mark Nelson Mark Nelson
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.