Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43261 Tidy up hacks in moodle-core-dialogue
  3. MDL-43259

M.core.dialogue lightbox attribute should have been deprecated in 2.2

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.6
    • JavaScript
    • MOODLE_26_STABLE
    • MOODLE_27_STABLE
    • MDL-43259-master
    • Hide
      • Open the login page
      • Open the help tooltip
        • Confirm that the dialogue was not shown modally
        • Confirm that there were no messages in the JS console
      • Log in
      • Open a course page and turn editing on
      • Open the activity chooser
        • Confirm that the dialogue was shown modally
        • Confirm that there were no messages in the JS console
      • Add an assignment and set it up
      • As a user enrolled on the course, navigate to the assignment
      • Open the file picker
        • Confirm that the dialogue was shown modally
        • Confirm that there were no messages in the JS console
      • Upload a PDF to the assignment and save
      • As a tutor, open the PDF editor
      • Select the stamp dropdown
        • Confirm that the dialogue was not shown modally
        • Confirm that there were no messages in the JS console
      • Open the comments search box
        • Confirm that the dialogue was shown modally
        • Confirm that there were no messages in the JS console
      • Edit lib/yui/src/chooserdialogue/js/chooserdialogue.js
      • Change 'modal: true' to 'lightbox: true' and re-shift the module
      • Refresh the course page
      • Open the activity chooser again
        • Confirm that the dialogue was still shown modally
        • Confirm that there was a message in the JS console warning of deprecation
      • Edit the code again to change 'lightbox: false'
      • Refresh
        • Confirm that the dialogue was not shown modally
        • Confirm that there was still a message in the JS console warning of deprecation
      Show
      Open the login page Open the help tooltip Confirm that the dialogue was not shown modally Confirm that there were no messages in the JS console Log in Open a course page and turn editing on Open the activity chooser Confirm that the dialogue was shown modally Confirm that there were no messages in the JS console Add an assignment and set it up As a user enrolled on the course, navigate to the assignment Open the file picker Confirm that the dialogue was shown modally Confirm that there were no messages in the JS console Upload a PDF to the assignment and save As a tutor, open the PDF editor Select the stamp dropdown Confirm that the dialogue was not shown modally Confirm that there were no messages in the JS console Open the comments search box Confirm that the dialogue was shown modally Confirm that there were no messages in the JS console Edit lib/yui/src/chooserdialogue/js/chooserdialogue.js Change 'modal: true' to 'lightbox: true' and re-shift the module Refresh the course page Open the activity chooser again Confirm that the dialogue was still shown modally Confirm that there was a message in the JS console warning of deprecation Edit the code again to change 'lightbox: false' Refresh Confirm that the dialogue was not shown modally Confirm that there was still a message in the JS console warning of deprecation

      We're doing some unpleasant things in M.core.dialogue which I wish to remove and tidy up.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Petr Skoda Petr Skoda
            Sam Hemelryk Sam Hemelryk
            Adrian Greeve Adrian Greeve
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.