Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 5.0.1
Affects Version/s: 5.0 regressions, 5.0
Component/s: JavaScript, Report builder
Labels:

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 5.0 Branch:
~~MDL-85264~~-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-85264-500?w=1
Pull Main Branch:
~~MDL-85264~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-85264?w=1
Testing Instructions:
Hide

Log in as admin

Navigate to Reports in user menu

Create new report

Navigate to report Audience tab

Press Manually added users

Select a user but do not save changes

Press Access tab

Confirm you see a "Changes made" warning

Press Cancel in the dialog

Confirm you are still on the Audience tab

Press Access tab (again)

Confirm you see a "Changes made" warning (again)

Press "X" in the dialog

Confirm you are still on the Audience tab

Press Access tab (yet again)

Confirm you see a "Changes made" warning (yet again)

Press Confirm in the dialog

Confirm you are now on the Access tab

Press Audience tab

Press Manually added users

Select a user and save changes

Press Access tab

Confirm there is no "Changes made" warning
Show
Log in as admin Navigate to Reports in user menu Create new report Navigate to report Audience tab Press Manually added users Select a user but do not save changes Press Access tab Confirm you see a "Changes made" warning Press Cancel in the dialog Confirm you are still on the Audience tab Press Access tab (again) Confirm you see a "Changes made" warning (again) Press "X" in the dialog Confirm you are still on the Audience tab Press Access tab (yet again) Confirm you see a "Changes made" warning (yet again) Press Confirm in the dialog Confirm you are now on the Access tab Press Audience tab Press Manually added users Select a user and save changes Press Access tab Confirm there is no "Changes made" warning
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-85264~~ using repository: https://github.com/paulholden/moodle/

MOODLE_500_STABLE (0 errors / 1 warnings) [branch: MDL-85264-500 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/1), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (0 errors / 1 warnings) [branch: MDL-85264 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/1), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Fri May 2 17:14:49 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85264 using repository: https://github.com/paulholden/moodle/ MOODLE_500_STABLE (0 errors / 1 warnings) [branch: MDL-85264-500 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/1) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (0 errors / 1 warnings) [branch: MDL-85264 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/1) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Fri May 2 17:14:49 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85264~~-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19179/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65547/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65548/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65549/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-85264~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19180/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65550/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65551/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65552/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65553/ App tests (stable app version) / complete) --> unrelated failure, please ignore.

Built on: Fri May 2 17:02:15 UTC 2025
Show
Launching automatic jobs for branch MDL-85264 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19179/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65547/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65548/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65549/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-85264 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19180/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65550/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65551/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65552/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65553/ App tests (stable app version) / complete) --> unrelated failure, please ignore. Built on: Fri May 2 17:02:15 UTC 2025

Story Points:
1
Sprint:
WP Sprint 2025-I2.0, WP Sprint 2025-I2.1 (Espresso)

See behaviour in 4.5:

We get a warning when editing a form in the Audience tab and then switching to the Schedules tab without saving the form

This is broken in 5.0 - nothing happens when switching tabs from a "dirty form" per form change checker module

Originally from ~~MDL-73007~~

Seems to be broken since some of these changes from ~~MDL-75669~~

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Screenshot 2025-04-23 at 13-13-18 Cohorts Moodle 4.5.png
72 kB
23/Apr/25 8:20 PM
MDL-85264.png
555 kB
21/May/25 11:01 AM

has a non-specific relationship to

MDL-85749 Fix behat when a modal is shown changing tabs in dirty state

Open

is a regression caused by

MDL-75669 Upgrade the Boost theme with Bootstrap 5.x

Closed

will help resolve

MDL-73007 When changing dynamic_tabs without saving a form, a warning should be displayed

Closed

links to

Navs and tabs | Bootstrap v5.0 | Events

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Alberto Sempreboni

Integrator:: Mikel Martín Corrales

Tester:: Ron Carl Alfon Yu

Participants:: Alberto Sempreboni, Amaia Anabitarte, CiBoT, Mikel Martín Corrales, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 23/Apr/25 8:16 PM

Updated:: 12/Jun/25 7:24 PM

Resolved:: 23/May/25 12:29 PM

Estimated:

Remaining:

Logged:

6h 17m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify