Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 5.0
Component/s: Automated functional tests (behat)
Labels:
- affects_workplace
- triaged

Affected Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/odeialba/moodle/
Pull Main Branch:
MDL-85749
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...odeialba:MDL-85749
Testing Instructions:
- Pull from branch
- Execute behat tests ("Warning on unsaved form when tab is changing")
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-85749 using repository: https://github.com/odeialba/moodle/

main (0 errors / 1 warnings) [branch: MDL-85749 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/1), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Thu Jun 12 09:36:25 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85749 using repository: https://github.com/odeialba/moodle/ main (0 errors / 1 warnings) [branch: MDL-85749 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/1) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Thu Jun 12 09:36:25 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85749

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67268/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67269/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67270/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67271/ App tests (stable app version) / complete)

Built on: Thu Jun 12 09:38:34 UTC 2025
Show
Launching automatic jobs for branch MDL-85749 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67268/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67269/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67270/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67271/ App tests (stable app version) / complete) Built on: Thu Jun 12 09:38:34 UTC 2025

Story Points:
3
Sprint:
WP Sprint 2025-I2.2 (Clones)

In workplace we have this issue WP-5399 which adds the modal that informs you that you have unsaved changes in a form when you are going to change the tab.

We added some tests to make sure that it works and they don't pass. I added the same tests in core and they don't pass either.

The problem is that behat is checking that M.util.pending_js is empty and since the modal has been changed changing the tab with shown.bs.tab it is never empty.

has been marked as being related by

MDL-85264 Dynamic tab changes no longer prompt form change checker

Closed

Assignee:: Unassigned

Reporter:: Odei Alba

Participants:: Odei Alba, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 11/Jun/25 11:20 PM

Updated:: 13/Jun/25 6:09 PM

Estimated:

Remaining:

Logged:

25m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify