Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Messages
Labels:
- ci
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Notification Improvements - Phase 2
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-84877~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/2f82f5fe8c...MDL-84877-main?w=1
Testing Instructions:
Hide

Testing instructions

Login as admin,

Go to Site administration / General / Messaging / Notification settings

In the Default notification preferences area enable "Assignment notifications"

Confirm that a toast is shown

Jump down the page and toggle something different

Confirm that a toast is shown and visible
Show
Testing instructions Login as admin, Go to Site administration / General / Messaging / Notification settings In the Default notification preferences area enable "Assignment notifications" Confirm that a toast is shown Jump down the page and toggle something different Confirm that a toast is shown and visible
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84877~~ using repository: https://github.com/andrewnicols/moodle.git

main (0 errors / 0 warnings) [branch: MDL-84877-main | CI Job]

_{More information about this report}

Built on: Fri Mar 14 08:49:39 UTC 2025
Show
Code verified against automated checks. Checked MDL-84877 using repository: https://github.com/andrewnicols/moodle.git main (0 errors / 0 warnings) [branch: MDL-84877-main | CI Job ] More information about this report Built on: Fri Mar 14 08:49:39 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84877~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18591/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63689/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63690/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63691/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63692/ App tests (stable app version)

Built on: Fri Mar 14 10:25:43 UTC 2025
Show
Launching automatic jobs for branch MDL-84877 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18591/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63689/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63690/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63691/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63692/ App tests (stable app version) Built on: Fri Mar 14 10:25:43 UTC 2025

See attached before/after examples..

The existing notifications are infuriating. They bump the page down as you're trying to click, and they only show at the top of the page so you don't actually get to see the notification if change preferences down the page.

Using a toast is much better.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-84877.png
87 kB
21/Mar/25 9:48 AM
(1) 4 Passed -- (Main)MDL-84877.png
113 kB
21/Mar/25 9:48 AM
after.mov
7.69 MB
14/Mar/25 2:34 PM
before.mov
10.83 MB
14/Mar/25 2:34 PM

is a regression caused by

MDL-73909 Notification settings toggle switches should save automatically

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Raquel Ortega

Integrator:: Paul Holden

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Kim Jared Lucas, Paul Holden, Raquel Ortega

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 14/Mar/25 2:32 PM

Updated:: 21/Mar/25 11:25 PM

Resolved:: 21/Mar/25 11:25 PM

Estimated:

Not Specified

Remaining:

Logged:

53m

Details

Testing instructions

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify