Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.0, Future Dev
Component/s: Messages, UX
Labels:
- ci
- developer_notes
- hqteam_hedgehog
- release_notes
- triaged
- ux

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Notification Improvements - Phase 2
Pull from Repository:
https://github.com/raortegar/moodle.git
Pull Main Branch:
~~MDL-73909~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...raortegar:moodle:MDL-73909-main
Testing Instructions:
Hide

Testing instructions

Login as admin,

Go to Site administration / General / Messaging / Notification settings

Confirm the save button is under Notification plugins

In the Default notification preferences area enable "Assignment notifications"

Reload the page and confirm the "Assignment notifications" is still enabled.

Play with other options, like enable web toggle, or email toggle, locked them..
Show
Testing instructions Login as admin, Go to Site administration / General / Messaging / Notification settings Confirm the save button is under Notification plugins In the Default notification preferences area enable "Assignment notifications" Reload the page and confirm the "Assignment notifications" is still enabled. Play with other options, like enable web toggle, or email toggle, locked them..
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-73909~~ using repository: https://github.com/raortegar/moodle.git

main (0 errors / 0 warnings) [branch: MDL-73909-main | CI Job]

_{More information about this report}

Built on: Mon 18 Nov 2024 12:49:54 PM UTC
Show
Code verified against automated checks. Checked MDL-73909 using repository: https://github.com/raortegar/moodle.git main (0 errors / 0 warnings) [branch: MDL-73909-main | CI Job ] More information about this report Built on: Mon 18 Nov 2024 12:49:54 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-73909~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17374/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59295/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59296/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59297/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59298/ App tests (stable app version)

Built on: Mon Nov 18 10:25:13 AM UTC 2024
Show
Launching automatic jobs for branch MDL-73909 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17374/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59295/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59296/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59297/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59298/ App tests (stable app version) Built on: Mon Nov 18 10:25:13 AM UTC 2024

Story Points:
10
Sprint:
Team Hedgehog 2024 Sprint 3.1, Team Hedgehog 2024 Sprint 3.2, Team Hedgehog 2024 Sprint 4.1, Team Hedgehog 2024 Sprint 4.2, Team Hedgehog 2024 Sprint 4.3, Team Hedgehog 2025 Sprint 1.0

I created a couple of issues related to ~~MDL-67853~~ and then closed them because I realised the problem was I didn't save the changes.

But then, talking with rezaie9 he shared with me he also faced the same issue and sent me this brilliant page: https://uxplanet.org/checkbox-vs-toggle-switch-7fc6e83f10b8

So, in that particular case, for the "Site administration > Notification settings" page it seems we should auto-save results if we keep the toggle switch or replace them with a checkbox if the Save changes button stays.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-73909.png
49 kB
09/Jan/25 12:56 PM
(1) 5 Passed -- (Main)MDL-73909.png
66 kB
09/Jan/25 12:56 PM
(1) 6 Passed -- (Main)MDL-73909.png
64 kB
09/Jan/25 12:56 PM
MDL-73909_Question.png
79 kB
17/Jul/24 1:42 AM
MDL-73909_str_notifications.png
41 kB
15/Nov/24 6:43 PM
MDL-73909_toggleMessages.png
112 kB
13/Nov/24 5:26 PM
savechanges_notification.png
90 kB
16/Oct/23 2:04 PM

caused a regression

MDL-84877 Swap Notifications for Toasts in notification preferences

Closed

has a non-specific relationship to

MDL-73892 Disabled notifications shouldn't be displayed in user preferences

Closed

MDL-73893 Locked notifications can be edited in the user preferences page

Closed

MDL-83702 Admin message notification toggle logs status updates incorrectly

Closed

has to be done before

MDL-83953 Update "Notification Plugins" Table in Notification Settings to Save on Toggle

Open

is a regression caused by

MDL-67853 Remove online-offline options on notifications.

Closed

(1 is a regression caused by)

Assignee:: Raquel Ortega

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: David Woloszyn

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, David Woloszyn, Julia Verdaguer, Jun Pataleta, Kim Jared Lucas, Matt Porritt, Raquel Ortega, Robert van_Garderen, Sara Arjona (@sarjona)

Votes:: 2 Vote for this issue

Watchers:: 13 Start watching this issue

Created:: 16/Feb/22 5:48 PM

Updated:: 11/Apr/25 5:40 PM

Resolved:: 09/Jan/25 10:39 PM

Estimated:

Not Specified

Remaining:

Logged:

1w 2d 4h 58m

Details

Testing instructions

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify