Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: AI
Labels:
- ci
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-84765~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84765
Testing Instructions:
1. Covered by automated tests (PHPUnit)
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84765~~ using repository: https://github.com/paulholden/moodle.git

main (0 errors / 0 warnings) [branch: MDL-84765 | CI Job]

_{More information about this report}

Built on: Mon Mar 10 10:26:11 UTC 2025
Show
Code verified against automated checks. Checked MDL-84765 using repository: https://github.com/paulholden/moodle.git main (0 errors / 0 warnings) [branch: MDL-84765 | CI Job ] More information about this report Built on: Mon Mar 10 10:26:11 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84765~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18505/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63332/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63333/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63334/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63335/ App tests (stable app version) --> unrelated failure, please ignore.

Built on: Mon Mar 10 10:25:14 UTC 2025
Show
Launching automatic jobs for branch MDL-84765 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18505/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63332/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63333/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63334/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63335/ App tests (stable app version) --> unrelated failure, please ignore. Built on: Mon Mar 10 10:25:14 UTC 2025

See the following, the tests in plugin \aiprovider_azureai are testing the provider from plugin \aiprovider_openai:

$ git grep openai ai/provider/azureai/tests/

ai/provider/azureai/tests/process_generate_image_test.php:            classname: '\aiprovider_openai\provider',

ai/provider/azureai/tests/process_generate_image_test.php:            classname: '\aiprovider_openai\provider',

ai/provider/azureai/tests/process_generate_text_test.php:            classname: '\aiprovider_openai\provider',

ai/provider/azureai/tests/process_generate_text_test.php:            classname: '\aiprovider_openai\provider',

ai/provider/azureai/tests/process_summarise_text_test.php:            classname: '\aiprovider_openai\provider',

ai/provider/azureai/tests/process_summarise_text_test.php:            classname: '\aiprovider_openai\provider',

ai/provider/azureai/tests/provider_test.php:            classname: '\aiprovider_openai\provider',

Breaks our inter-component rules, etc. However it's more likely to just be copy/paste errors from ~~MDL-82977~~ & I assume the plugin tests should be asserting behaviour of itself

Also the @covers notation is wrong in some of them

has a non-specific relationship to

MDL-84766 Cannot create/configure new AI provider instance if OpenAI not present

Closed

is a regression caused by

MDL-82977 AI: Provider instances

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Tasio Bertomeu

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, Jun Pataleta, Paul Holden, Sara Arjona (@sarjona), Tasio Bertomeu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 07/Mar/25 2:06 AM

Updated:: 11/Mar/25 8:29 PM

Resolved:: 11/Mar/25 8:29 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 7m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify