Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5 regressions, 4.5
Component/s: Grading methods
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
MDL-84739-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84739-405
Pull 5.0 Branch:
MDL-84739-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-84739-500
Pull Main Branch:
MDL-84739
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84739
Testing Instructions:
Hide

Log in as admin

Create a course

Create a forum in course

Press Advanced grading

Change active grading method to Rubric

Press Define new grading form from scratch

Under the Rubric table, press Add criterion

Confirm all the icons in the table are appropriately sized (i.e. not massive)
Show
Log in as admin Create a course Create a forum in course Press Advanced grading Change active grading method to Rubric Press Define new grading form from scratch Under the Rubric table, press Add criterion Confirm all the icons in the table are appropriately sized (i.e. not massive)
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-84739 using repository: https://github.com/paulholden/moodle.git

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-84739-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-84739-405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84739-500 | CI Job]

main (0 errors / 1 warnings) [branch: MDL-84739 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-84739 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Mon Apr 28 10:46:14 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84739 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-84739-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84739 -405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84739-500 | CI Job ] main (0 errors / 1 warnings) [branch: MDL-84739 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84739 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Mon Apr 28 10:46:14 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-84739-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18701/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64068/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64069/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84739

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18702/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64070/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64071/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64072/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64073/ App tests (stable app version)

Built on: Thu Mar 20 06:30:19 UTC 2025
Show
Launching automatic jobs for branch MDL-84739 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18701/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64068/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64069/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84739 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18702/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64070/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64071/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64072/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64073/ App tests (stable app version) Built on: Thu Mar 20 06:30:19 UTC 2025

Steps to reproduce:

Create a forum with grading
Go to "advanced grading" and change active grading method to rubric
Click on "define new grading form form scratch"
Add one criteria to the rubric.

Expected: the form should look like in 4.4

What happens: the icons are black and big and affects the layout (in both 4.5 and Main)

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

84739 peer review - test 404.png
33 kB
20/Mar/25 12:28 PM
84739 peer review - test 405.png
32 kB
20/Mar/25 12:28 PM
84739 peer review - test main.png
34 kB
20/Mar/25 12:28 PM
Screenshot from 2025-03-05 10-49-56.png
31 kB
05/Mar/25 5:53 PM
Screenshot from 2025-03-05 10-50-11.png
34 kB
05/Mar/25 5:53 PM

has been marked as being related by

MDL-76603 Accessibility fixes for assignment with advanced grading methods

Closed

is a regression caused by

MDL-82497 Update icon_map with the latest icons from Font Awesome 6 (core)

Closed

is duplicated by

MDL-85219 UI/UX problems in Define rubric

Closed

mentioned in: Page Loading...

Assignee:: Paul Holden

Reporter:: Ferran Recio

Peer reviewer:: Andrew Gosali

Participants:: Andrew Gosali, CiBoT, Ferran Recio, Jun Pataleta, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 05/Mar/25 5:51 PM

Updated:: 13/Jun/25 4:05 PM

Estimated:

Remaining:

Logged:

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify