Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.17, 4.3.11, 4.4.7, 4.5.3
Affects Version/s: 4.1.17, 4.3.11, 4.4.2, 4.5.3
Component/s: Accessibility
Labels:
- ci

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-84595~~-401
Pull 4.1 Diff URL:
https://github.com/HuongNV13/moodle/compare/99445f3...MDL-84595-401
Pull 4.3 Branch:
~~MDL-84595~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/5e7cde3baf...MDL-84595-403?w=1
Pull 4.4 Branch:
~~MDL-84595~~-404
Pull 4.4 Diff URL:
https://github.com/andrewnicols/moodle/compare/9508120293...MDL-84595-404?w=1
Pull 4.5 Branch:
~~MDL-84595~~-405
Pull 4.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/3c848c4dce...MDL-84595-405?w=1
Pull Main Branch:
~~MDL-84595~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/77a7d81290...MDL-84595-main?w=1
Testing Instructions:
Hide

4.1

Initialise behat

Open blocks/myoverview/tests/behat/block_myoverview_dashboard.feature.

Find "Then the page should meet "wcag143" accessibility standards"

Replace it with the following line:

Then the "Course overview" "block" should meet accessibility standards

Open /blocks/myoverview/templates/main.mustache in your editor

Find the first div tag with the class d-flex align-items-center

Add the following classes to the tag: bg-dark text-dark

Run the following test:
File: blocks/myoverview/tests/behat/block_myoverview_dashboard.feature
Scenario: The dashboard page must have sufficient colour contrast

Confirm it fails

4.3 and up

Initialise behat

Open blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature

Find "And the page should meet accessibility standards" in the "User has accessed some items" scenario

Replace it with the following line:

And the "Recently accessed items" "block" should meet accessibility standards

Open /blocks/recentlyaccesseditems/templates/view-cards.mustache in your editor

Find the first div tag with the class card mb-1

Add the following classes to the tag: bg-dark text-dark

Run the following test:
File: blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature
Scenario: User has accessed some items

Confirm it fails
Show
4.1 Initialise behat Open blocks/myoverview/tests/behat/block_myoverview_dashboard.feature. Find "Then the page should meet "wcag143" accessibility standards" Replace it with the following line: Then the "Course overview" "block" should meet accessibility standards Open /blocks/myoverview/templates/main.mustache in your editor Find the first div tag with the class d-flex align-items-center Add the following classes to the tag: bg-dark text-dark Run the following test: File: blocks/myoverview/tests/behat/block_myoverview_dashboard.feature Scenario: The dashboard page must have sufficient colour contrast Confirm it fails 4.3 and up Initialise behat Open blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature Find "And the page should meet accessibility standards" in the "User has accessed some items" scenario Replace it with the following line: And the "Recently accessed items" "block" should meet accessibility standards Open /blocks/recentlyaccesseditems/templates/view-cards.mustache in your editor Find the first div tag with the class card mb-1 Add the following classes to the tag: bg-dark text-dark Run the following test: File: blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature Scenario: User has accessed some items Confirm it fails
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84595~~ using repository: https://github.com/andrewnicols/moodle.git

MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-84595-401 | CI Job]

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-84595-403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84595-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84595-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84595-main | CI Job]

_{More information about this report}

Built on: Thu Feb 20 03:05:26 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84595 using repository: https://github.com/andrewnicols/moodle.git MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-84595-401 | CI Job ] MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-84595-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84595-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84595-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84595-main | CI Job ] More information about this report Built on: Thu Feb 20 03:05:26 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84595~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18323/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62675/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62676/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84595~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18324/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62677/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62678/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84595~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18325/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62679/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62680/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84595~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18326/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62681/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62682/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84595~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18327/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62683/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62684/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62685/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62686/ App tests (stable app version)

Built on: Thu Feb 20 04:25:26 PM UTC 2025
Show
Launching automatic jobs for branch MDL-84595 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18323/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62675/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62676/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84595 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18324/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62677/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62678/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84595 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18325/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62679/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62680/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84595 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18326/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62681/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62682/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84595 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18327/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62683/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62684/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62685/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62686/ App tests (stable app version) Built on: Thu Feb 20 04:25:26 PM UTC 2025

We should be able to test wihtin a specific Node Selector rather than just the whole page.
This is particularly useful for plugin developers or new feature development where other parts of the page prevent us from testing this currently.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84595.png
04/Mar/25 2:32 PM
107 kB
Ron Carl Alfon Yu

is blocked by

MDL-84590 Behat AXE testing uses wrong rules

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Simey Lameze

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Ron Carl Alfon Yu, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 20/Feb/25 10:57 AM

Updated:: 18/Mar/25 4:51 PM

Resolved:: 04/Mar/25 11:30 PM

Estimated:

Remaining:

Logged:

4h 20m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify