Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: 4.1.17, 4.3.11, 4.4.7, 4.5.3
Affects Version/s: 4.1.17, 4.3.11, 4.4.7, 4.5.3
Component/s: Accessibility
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-84590~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/2a753faf06...MDL-84590-401?w=1
Pull 4.3 Branch:
~~MDL-84590~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/42a8b0c521...MDL-84590-403?w=1
Pull 4.4 Branch:
~~MDL-84590~~-404
Pull 4.4 Diff URL:
https://github.com/andrewnicols/moodle/compare/9508120293...MDL-84590-404?w=1
Pull 4.5 Branch:
~~MDL-84590~~-405
Pull 4.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/3c848c4dce...MDL-84590-405?w=1
Pull Main Branch:
~~MDL-84590~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/77a7d81290...MDL-84590-main?w=1
Testing Instructions:
Hide

4.1

Initialise behat

Run the following test:
File: blocks/myoverview/tests/behat/block_myoverview_dashboard.feature
Scenario: The dashboard page must have sufficient colour contrast

Confirm it passes

Open /blocks/myoverview/templates/main.mustache in your editor

Find the first div tag with the class d-flex align-items-center

Add the following classes to the tag: bg-dark text-dark

Run the following test:
File: blocks/myoverview/tests/behat/block_myoverview_dashboard.feature
Scenario: The dashboard page must have sufficient colour contrast

Confirm it fails

4.3 and up

Initialise behat

Run the following test:
File: blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature
Scenario: User has accessed some items

Confirm it passes

Open /blocks/recentlyaccesseditems/templates/view-cards.mustache in your editor

Find the first div tag with the class card mb-1

Add the following classes to the tag: bg-dark text-dark

Run the following test:
File: blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature
Scenario: User has accessed some items

Confirm it fails
Show
4.1 Initialise behat Run the following test: File: blocks/myoverview/tests/behat/block_myoverview_dashboard.feature Scenario: The dashboard page must have sufficient colour contrast Confirm it passes Open /blocks/myoverview/templates/main.mustache in your editor Find the first div tag with the class d-flex align-items-center Add the following classes to the tag: bg-dark text-dark Run the following test: File: blocks/myoverview/tests/behat/block_myoverview_dashboard.feature Scenario: The dashboard page must have sufficient colour contrast Confirm it fails 4.3 and up Initialise behat Run the following test: File: blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature Scenario: User has accessed some items Confirm it passes Open /blocks/recentlyaccesseditems/templates/view-cards.mustache in your editor Find the first div tag with the class card mb-1 Add the following classes to the tag: bg-dark text-dark Run the following test: File: blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature Scenario: User has accessed some items Confirm it fails
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84590~~ using repository: https://github.com/andrewnicols/moodle.git

MOODLE_401_STABLE (0 errors / 1 warnings) [branch: MDL-84590-401 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-84590~~-401 branch at https://github.com/andrewnicols/moodle.git has not been rebased recently (>20 days ago).

MOODLE_403_STABLE (0 errors / 1 warnings) [branch: MDL-84590-403 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-84590~~-403 branch at https://github.com/andrewnicols/moodle.git has not been rebased recently (>20 days ago).

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84590-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84590-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84590-main | CI Job]

Should these errors be fixed?

Built on: Thu Feb 20 02:20:16 AM UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84590 using repository: https://github.com/andrewnicols/moodle.git MOODLE_401_STABLE (0 errors / 1 warnings) [branch: MDL-84590-401 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84590 -401 branch at https://github.com/andrewnicols/moodle.git has not been rebased recently (>20 days ago). MOODLE_403_STABLE (0 errors / 1 warnings) [branch: MDL-84590-403 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84590 -403 branch at https://github.com/andrewnicols/moodle.git has not been rebased recently (>20 days ago). MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84590-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84590-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84590-main | CI Job ] Should these errors be fixed? Built on: Thu Feb 20 02:20:16 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84590~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18309/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62606/ Behat (NonJS - boost and classic / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62607/ Behat (Firefox - boost / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62608/ Behat (Firefox - classic / --tags @accessibility)

Launching automatic jobs for branch ~~MDL-84590~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18310/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62609/ Behat (NonJS - boost and classic / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62610/ Behat (Firefox - boost / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62611/ Behat (Firefox - classic / --tags @accessibility)

Launching automatic jobs for branch ~~MDL-84590~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18311/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62612/ Behat (NonJS - boost and classic / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62613/ Behat (Firefox - boost / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62614/ Behat (Firefox - classic / --tags @accessibility)

Launching automatic jobs for branch ~~MDL-84590~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18312/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62615/ Behat (NonJS - boost and classic / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62616/ Behat (Firefox - boost / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62617/ Behat (Firefox - classic / --tags @accessibility)

Launching automatic jobs for branch ~~MDL-84590~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18313/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62618/ Behat (NonJS - boost and classic / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62619/ Behat (Firefox - boost / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62620/ Behat (Firefox - classic / --tags @accessibility)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62621/ App tests (stable app version) / --tags @accessibility)

Built on: Thu Feb 20 02:00:42 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84590 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18309/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62606/ Behat (NonJS - boost and classic / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62607/ Behat (Firefox - boost / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62608/ Behat (Firefox - classic / --tags @accessibility) Launching automatic jobs for branch MDL-84590 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18310/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62609/ Behat (NonJS - boost and classic / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62610/ Behat (Firefox - boost / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62611/ Behat (Firefox - classic / --tags @accessibility) Launching automatic jobs for branch MDL-84590 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18311/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62612/ Behat (NonJS - boost and classic / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62613/ Behat (Firefox - boost / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62614/ Behat (Firefox - classic / --tags @accessibility) Launching automatic jobs for branch MDL-84590 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18312/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62615/ Behat (NonJS - boost and classic / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62616/ Behat (Firefox - boost / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62617/ Behat (Firefox - classic / --tags @accessibility) Launching automatic jobs for branch MDL-84590 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18313/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62618/ Behat (NonJS - boost and classic / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62619/ Behat (Firefox - boost / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62620/ Behat (Firefox - classic / --tags @accessibility) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62621/ App tests (stable app version) / --tags @accessibility) Built on: Thu Feb 20 02:00:42 AM UTC 2025

~~MDL-79674~~ swapped our Axe integration from wcag2a and wcag2aa to wcag21a and wcag21aa.
~~MDL-82553~~ swapped thenswapped them to wcag22a and wcag22aa

Unfortunately though the rules are not additive.

By swapping to wcag21a, wcag22a, wcag21aa, and wcag22aa and removing the original wcag2a, and wcag2aa rules we no longer test the original rules!

You can test this by setting the background colour for the recentlyaccessitems blocks to have bg-dark and text-dark on the same class. This should cause the blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature rules to fail, but it does not.

Adding the wcag2a and wcag2aa rules back to the mix then causes it to fail.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 6 Passed -- (403)MDL-84590.png
114 kB
20/Feb/25 5:31 PM
(1) 6 Passed -- (404)MDL-84590.png
113 kB
20/Feb/25 5:31 PM
(1) 6 Passed -- (405)MDL-84590.png
122 kB
20/Feb/25 5:31 PM
result_4.1_1.png
541 kB
20/Feb/25 6:40 PM
result_4.1_2.png
1.46 MB
20/Feb/25 6:41 PM
result_main_1.png
696 kB
20/Feb/25 6:46 PM
result_main_2.png
1.50 MB
20/Feb/25 6:48 PM

blocks

MDL-84592 Behat AXE failures are unhelpful

Closed

MDL-84595 Behat Axe steps should allow node specification

Closed

is a regression caused by

MDL-79674 Upgrade axe-core to 4.8.4

Closed

MDL-82553 Run accessibility Behat tests against WCAG 2.2 by default

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Simey Lameze

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, Brett Dalton, CiBoT, Huong Nguyen, Jun Pataleta, Marina Glancy, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 20/Feb/25 7:27 AM

Updated:: 18/Mar/25 5:56 PM

Resolved:: 21/Feb/25 11:46 AM

Estimated:

Remaining:

Logged:

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify