Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.4.6, 4.5.2
Component/s: Questions
Labels:
- ci
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Quiz and Question bank in Moodle 5.0
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-84558~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/commit/MDL-84558
Testing Instructions:

Hide

This is just clarifying a comment, with some related cosmetic changes in the code to make it clearer.

Therefore, the only testing required is a CI run, to ensure there are no regressions.

Show
This is just clarifying a comment, with some related cosmetic changes in the code to make it clearer. Therefore, the only testing required is a CI run, to ensure there are no regressions.
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84558~~ using repository: https://github.com/timhunt/moodle.git

main (0 errors / 1 warnings) [branch: MDL-84558 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: the branch is based off integration.git

Should these errors be fixed?

Built on: Tue Feb 18 03:56:15 PM UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84558 using repository: https://github.com/timhunt/moodle.git main (0 errors / 1 warnings) [branch: MDL-84558 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: the branch is based off integration.git Should these errors be fixed? Built on: Tue Feb 18 03:56:15 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84558~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18294/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62547/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62548/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62549/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62550/ App tests (stable app version) / complete)

Built on: Tue Feb 18 03:56:17 PM UTC 2025
Show
Launching automatic jobs for branch MDL-84558 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18294/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62547/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62548/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62549/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62550/ App tests (stable app version) / complete) Built on: Tue Feb 18 03:56:17 PM UTC 2025

The default_sort method does not really document what the return value means.

It turns out that the values in the array returned are not used. The PHPdoc should explain this.

Discovered while testing

MDL-84341 Issue with version display order in question history

Closed

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: CMR

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, CMR, Jun Pataleta, Simey Lameze, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 17/Feb/25 7:43 PM

Updated:: 08/Mar/25 12:17 PM

Resolved:: 08/Mar/25 12:17 PM

Estimated:

Not Specified

Remaining:

Logged:

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify