Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5.2
Component/s: General
Labels:
- ci
- triaged

Affected Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
MDL-84531-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84531-405
Pull 5.0 Branch:
MDL-84531-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-84531-500
Pull Main Branch:
MDL-84531
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84531
Testing Instructions:
Hide

Download MDL-84531.php to Moodle web root

Execute the following from CLI:

$ php ./MDL-84531.php

Confirm you see the following output, instead of a runtime exception:

Deprecation: course_format_ajax_support has been deprecated since 5.0. See MDL-82351 for more information.
Show
Download MDL-84531.php to Moodle web root Execute the following from CLI: $ php ./MDL-84531.php Confirm you see the following output, instead of a runtime exception: Deprecation: course_format_ajax_support has been deprecated since 5.0. See MDL-82351 for more information.
Pre-check results:
Hide

Fails against automated checks.

Checked MDL-84531 using repository: https://github.com/paulholden/moodle.git

main (1 errors / 0 warnings) [branch: MDL-84531 | CI Job]

overview (0/0), phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Thu Jun 12 14:06:21 UTC 2025
Show
Fails against automated checks. Checked MDL-84531 using repository: https://github.com/paulholden/moodle.git main (1 errors / 0 warnings) [branch: MDL-84531 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (1/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Thu Jun 12 14:06:21 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-84531-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19681/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67300/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67301/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84531-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19682/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67302/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67303/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84531

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19683/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67304/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67305/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67306/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67307/ App tests (stable app version)

Built on: Thu Jun 12 16:30:22 UTC 2025
Show
Launching automatic jobs for branch MDL-84531 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19681/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67300/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67301/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84531 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19682/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67302/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67303/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84531 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19683/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67304/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67305/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67306/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67307/ App tests (stable app version) Built on: Thu Jun 12 16:30:22 UTC 2025

See discussion originating from ~~MDL-78304~~ - there is some deprecated annotation landing (one example) with incorrectly populated parameters, which cause PHP engine exceptions rather then presenting helpful deprecation information to the users:

Exception - core\attribute\deprecated::__construct(): Argument #1 ($replacement) not passed

More information about this error

Debug info:

Error code: generalexceptionmessage

Stack trace:

    line 42 of /lib/classes/attribute/deprecated.php: ArgumentCountError thrown

    line 323 of /mnet/peer.php: call to core\attribute\deprecated->__construct()

Fix them

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84531.php
12/Jun/25 9:48 PM
0.2 kB
Paul Holden

Discovered while testing

MDL-78304 Moodle 5.0 mnet final deprecation

Closed

has been marked as being related by

MDL-78375 Final deprecation of device related theme functions

Component lead review in progress

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Daniel Ziegenberg

Participants:: Daniel Ziegenberg, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 14/Feb/25 12:14 AM

Updated:: 13/Jun/25 12:30 AM

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Clockify