Loading...

XML

Word

Printable

Type: Task
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.3
Component/s: Themes
Labels:
- triaged

Affected Branches:
MOODLE_403_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
MDL-78375_final-deprecation-of-device-related-theme-functions
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-78375_final-deprecation-of-device-related-theme-functions

Testing Instructions:

Hide

Execute the following:

git grep -C2 -E 'get_device_type_(theme|cfg_var_name)\('

git grep -C2 -E 'theme_is_device_locked\('

git grep -C2 -E 'theme_get_locked_theme_for_device\('

Confirm the only matches are the original methods and function (which emit a final deprecation notice) and upgrade notes regarding the removal

Show

Execute the following: git grep -C2 -E 'get_device_type_(theme|cfg_var_name)\(' git grep -C2 -E 'theme_is_device_locked\(' git grep -C2 -E 'theme_get_locked_theme_for_device\(' Confirm the only matches are the original methods and function (which emit a final deprecation notice) and upgrade notes regarding the removal

Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-78375 using repository: https://github.com/ziegenberg/moodle

main (0 errors / 0 warnings) [branch: MDL-78375_final-deprecation-of-device-related-theme-functions | CI Job]

_{More information about this report}

Built on: Tue Jun 10 15:16:23 UTC 2025
Show
Code verified against automated checks. Checked MDL-78375 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-78375_final-deprecation-of-device-related-theme-functions | CI Job ] More information about this report Built on: Tue Jun 10 15:16:23 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-78375_final-deprecation-of-device-related-theme-functions

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19654/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67188/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67189/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67190/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67191/ App tests (stable app version)

Built on: Wed Jun 11 02:30:52 UTC 2025
Show
Launching automatic jobs for branch MDL-78375 _final-deprecation-of-device-related-theme-functions https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19654/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67188/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67189/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67190/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67191/ App tests (stable app version) Built on: Wed Jun 11 02:30:52 UTC 2025

This follow-up issue is connected to ~~MDL-77793~~ where the deprecation the of device related theme functions and strings were performed.

In this final step, we need to remove from lib/classes/useragent.php

get_device_type_theme
get_device_type_cfg_var_name

In this final step, we need to remove from lib/deprecatedlib.php

theme_get_locked_theme_for_device
theme_is_device_locked

There were strings that were deprecated in relation to this, but I believe these are covered in ~~MDL-76565~~

Likewise, there are functions that were deprecated and moved to lib/deprecatedlib.php and covered in ~~MDL-76561~~

has a non-specific relationship to

MDL-84531 Fix incorrect deprecated annotation content

Waiting for component lead review

has been marked as being related by

MDL-85711 PR only: MDL-78375 - Final deprecation of device related theme functions

Closed

has to be done after

MDL-77793 Remove the legacy theme selector

Closed

Assignee:: Daniel Ziegenberg

Reporter:: David Woloszyn

Peer reviewer:: Meirza

Integrator:: David Woloszyn

Participants:: CiBoT, Daniel Ziegenberg, David Woloszyn, Meirza, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 29/May/23 11:02 AM

Updated:: 12/Jun/25 6:01 PM

Estimated:

Not Specified

Remaining:

Logged:

2h 59m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify