-
Bug
-
Resolution: Fixed
-
Minor
-
4.4.4
-
MOODLE_404_STABLE
-
MOODLE_404_STABLE, MOODLE_405_STABLE
-
MDL-83648_404 -
MDL-83648_405 -
To be able to test this, there needs to be a way to fake a JavaScript error of the right type, and the easiest way is to fake it:
Hack code to simulate an error
- Download and apply the test patch MDL-83648-TEST.patch
that changes repository/draftfiles_ajax.php to trigger the error affected by this issue.
- git apply /path/to/
MDL-83648-TEST.patch
- git apply /path/to/
Do the test
- Using a mobile phone, or browser developer tools simulating a mobile,
- Log into Moodle and go to the edit profile screen (e.g. https://qa.moodledemo.net/user/edit.php?id=3&returnto=profile logged in as teacher.)
- Scroll down to the User picture filepicker
- Drag an image file in there.
- Click on the file to open a pop-up.
- Click the 'Delete' button in the popup.
- Confirm the 'Are you sure'
- Verify that the error message dialogue appears fitted to the phone screen, not overlapping. (See attached screen-grab for the previous, buggy, behaviour.)
To be able to test this, there needs to be a way to fake a JavaScript error of the right type, and the easiest way is to fake it: Hack code to simulate an error Download and apply the test patch MDL-83648-TEST.patch that changes repository/draftfiles_ajax.php to trigger the error affected by this issue. git apply /path/to/ MDL-83648 -TEST.patch Do the test Using a mobile phone, or browser developer tools simulating a mobile, Log into Moodle and go to the edit profile screen (e.g. https://qa.moodledemo.net/user/edit.php?id=3&returnto=profile logged in as teacher.) Scroll down to the User picture filepicker Drag an image file in there. Click on the file to open a pop-up. Click the 'Delete' button in the popup. Confirm the 'Are you sure' Verify that the error message dialogue appears fitted to the phone screen, not overlapping. (See attached screen-grab for the previous, buggy, behaviour.) - Download and apply the test patch MDL-83648-TEST.patch
-
Code verified against automated checks with warnings.Checked
MDL-83648using repository: https://github.com/timhunt/moodle.git
MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83648_404 | CI Job]
- overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),
- Warn: The
MDL-83648_404 branch at https://github.com/timhunt/moodle.git has not been rebased recently (>20 days ago).
- MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83648_405 | CI Job]
- overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),
- Warn: The
MDL-83648_405 branch at https://github.com/timhunt/moodle.git has not been rebased recently (>20 days ago).
- main (0 errors / 1 warnings) [branch: MDL-83648 | CI Job]
- overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),
- Warn: The
MDL-83648branch at https://github.com/timhunt/moodle.git has not been rebased recently (>20 days ago).
Built on: Tue 26 Nov 2024 12:24:44 AM UTC
Code verified against automated checks with warnings. Checked MDL-83648 using repository: https://github.com/timhunt/moodle.git MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83648_404 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83648 _404 branch at https://github.com/timhunt/moodle.git has not been rebased recently (>20 days ago). MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83648_405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83648 _405 branch at https://github.com/timhunt/moodle.git has not been rebased recently (>20 days ago). main (0 errors / 1 warnings) [branch: MDL-83648 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83648 branch at https://github.com/timhunt/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Tue 26 Nov 2024 12:24:44 AM UTC -
Steps to reproduce (one of many possible ways - just need to trigger an error in JavaScript code which causes the Notification.exception pop-up or dialogue to appear):
- Using a mobile phone, or browser developer tools simulating a mobile,
- Log into Moodle and go to the edit profile screen (e.g. https://qa.moodledemo.net/user/edit.php?id=3&returnto=profile logged in as teacher.)
- Scroll down to the User picture filepicker, and upload a new picture by clicking the + icon (not drag-drop).
- Choose a file not of the expected type (e.g. a .txt file.)
- Click 'Upload this file'.
Actual result:
Expected result: Moodle dialouges should do if (this.shouldResizeFullscreen())
{ this.makeResponsive(); }So the dialogue becomes full screen if it won't fit. Why is that not working here?
Note: I just realised that MDL-80689 will spoil the steps to reproduce I gave above.
