Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.4 regressions, 4.4, 4.4.5, 4.5
Component/s: Blocks, Course
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-83128~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83128-404
Pull 4.5 Branch:
~~MDL-83128~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83128-405
Pull Main Branch:
~~MDL-83128~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83128
Testing Instructions:
Hide

405 & 404 only

Log in as admin

Create a new course using the Social course format

Turn editing on

Open sidebar, add a URL activity to the Social activities block

Press Move for an activity in the same block

Confirm the subsequent move icon is correctly aligned above the name of the activity
Show
405 & 404 only Log in as admin Create a new course using the Social course format Turn editing on Open sidebar, add a URL activity to the Social activities block Press Move for an activity in the same block Confirm the subsequent move icon is correctly aligned above the name of the activity
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83128~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83128-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83128-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83128 | CI Job]

_{More information about this report}

Built on: Mon 02 Dec 2024 09:40:03 AM UTC
Show
Code verified against automated checks. Checked MDL-83128 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83128-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83128-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83128 | CI Job ] More information about this report Built on: Mon 02 Dec 2024 09:40:03 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83128~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17541/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59731/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59732/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83128~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17542/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59733/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59734/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83128~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17543/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59735/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59736/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59737/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59738/ App tests (stable app version)

Built on: Wed Nov 27 06:25:21 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83128 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17541/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59731/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59732/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83128 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17542/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59733/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59734/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83128 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17543/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59735/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59736/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59737/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59738/ App tests (stable app version) Built on: Wed Nov 27 06:25:21 AM UTC 2024

Steps to reproduce

Create a course using the Social format.
Enable edit mode.
Add the Social activities block.
At, at least, one activity.
Click the move button near any of the activities in the Activities block

Current behaviour

The move icon is still displayed and it overlaps the text:

In Moodle 4.3 it's working as expected:

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 6 Passed -- (405)MDL-83128.png
04/Dec/24 11:02 AM
56 kB
Kim Jared Lucas
image-2024-09-13-10-55-15-626.png
13/Sep/24 4:55 PM
30 kB
Laurent David
moodle403.png
13/Sep/24 4:46 PM
17 kB
Sara Arjona (@sarjona)
moodle405.png
13/Sep/24 4:47 PM
21 kB
Sara Arjona (@sarjona)

Discovered while testing

MDL-83124 Revert the t/move icon to arrows-up-down

Closed

is a regression caused by

MDL-78284 Implement the new activity icons design

Closed

will be (partly) resolved by

MDL-82351 Make social format compatible with the new course editor

Closed

Assignee:: Paul Holden

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: CiBoT, Huong Nguyen, Kim Jared Lucas, Laurent David, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 13/Sep/24 4:46 PM

Updated:: 06/Dec/24 12:49 AM

Resolved:: 06/Dec/24 12:49 AM

Estimated:

Remaining:

Logged:

2h 1m

Details

405 & 404 only

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify