Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82284

Remove deprecated PHP <7 constructors

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5
    • General
    • None

      In a variety of MDLs we added fallbacks for legacy constructors. It's time they were removed.

      Example:

       
      		 
          /**
      		 
           * Old syntax of class constructor. Deprecated in PHP7.
      		 
           *
      		 
           * @deprecated since Moodle 3.1
      		 
           */
      		 
          public function auth_plugin_cas() {
      		 
              debugging('Use of class name as constructor is deprecated', DEBUG_DEVELOPER);
      		 
              self::__construct();
      		 
          }

      I believe these can be straight deprecated as I don't believe it's possible to call them in any current version of PHP in a meaningful way.

      Proof: https://3v4l.org/qoPc3

            Unassigned Unassigned
            dobedobedoh Andrew Lyons
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.