Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81523

setUp/tearDown/setUpBeforeClass/tearDownAfterClass should call parent methods

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.5
    • 4.5
    • Unit tests
    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • Hide

      Regression testing.

      1. Verify that all the PHPUnit executions in the issue (GHA, CI, ...) are passing ok.

      Completeness testing (requires PR#165 to be merged and released).

      1. Install moodle-cs following the instructions.
      2. Run the following command:

        path/to/phpcs --standard=moodle \
            --sniffs=moodle.PHPUnit.ParentSetUpTearDown \
            -s -p /path/to/your/moodle
        

      3. Wait the execution to finish (you should see some progress with dots...). Can be some good minutes (~10 minutes here) to examine all the code.
      4. Verify that there isn't any problem reported (the output, after the dots, only reports the execution time and the memory used). The end of the output has to look similar to this:

        ...
        ...
        ............................................................ 18360 / 18404 (100%)
        ............................................                 18404 / 18404 (100%)
         
         
        Time: 9 mins, 49.47 secs; Memory: 308.01M
        

      Show
      Regression testing. Verify that all the PHPUnit executions in the issue (GHA, CI, ...) are passing ok. Completeness testing (requires PR#165 to be merged and released). Install moodle-cs following the instructions . Run the following command: path/to/phpcs --standard=moodle \ --sniffs=moodle.PHPUnit.ParentSetUpTearDown \ -s -p /path/to/your/moodle Wait the execution to finish (you should see some progress with dots...). Can be some good minutes (~10 minutes here) to examine all the code. Verify that there isn't any problem reported (the output, after the dots, only reports the execution time and the memory used). The end of the output has to look similar to this: ... ... ............................................................ 18360 / 18404 (100%) ............................................ 18404 / 18404 (100%)     Time: 9 mins, 49.47 secs; Memory: 308.01M

      setUp/tearDown/setUpBeforeClass/tearDownAfterClass should call parent methods

      We're going to need this in PHPUnit 10 because we can no longer wrap runBare.

            stronk7 Eloy Lafuente (stronk7)
            dobedobedoh Andrew Lyons
            Andrew Lyons Andrew Lyons
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 28 minutes
                6h 28m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.