Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.4.5, 4.5.1
Component/s: Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Migrate to PHPUnit 11
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.4 Branch:
~~MDL-83472~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83472-404
Pull 4.5 Branch:
~~MDL-83472~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83472-405
Pull Main Branch:
~~MDL-83472~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83472
Testing Instructions:
Hide

Setup

Install PHP Codesniffer

main & 405 branches

Execute the following from your Moodle root directory:

$ phpcs --standard=moodle --sniffs=moodle.PHPUnit.ParentSetUpTearDown -s -p .

Confirm it completes without any sniff errors

main, 405 & 404 branches

Execute the following from your Moodle root directory:

$ phpcs --standard=moodle --sniffs=moodle.PHPUnit.TestReturnType -s -p .

Confirm it completes without any sniff errors
Show
Setup Install PHP Codesniffer main & 405 branches Execute the following from your Moodle root directory: $ phpcs --standard=moodle --sniffs=moodle.PHPUnit.ParentSetUpTearDown -s -p . Confirm it completes without any sniff errors main, 405 & 404 branches Execute the following from your Moodle root directory: $ phpcs --standard=moodle --sniffs=moodle.PHPUnit.TestReturnType -s -p . Confirm it completes without any sniff errors
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83472~~ using repository: https://github.com/paulholden/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83472-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83472-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83472 | CI Job]

_{More information about this report}

Built on: Wed 16 Oct 2024 03:24:11 PM UTC
Show
Code verified against automated checks. Checked MDL-83472 using repository: https://github.com/paulholden/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83472-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83472-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83472 | CI Job ] More information about this report Built on: Wed 16 Oct 2024 03:24:11 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83472~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17050/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58044/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58045/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83472~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17051/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58046/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58047/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83472~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17052/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58048/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58049/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58050/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58051/ App tests (stable app version)

Built on: Mon Oct 21 04:30:54 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83472 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17050/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58044/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58045/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83472 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17051/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58046/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58047/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83472 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17052/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58048/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58049/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58050/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58051/ App tests (stable app version) Built on: Mon Oct 21 04:30:54 AM UTC 2024

This is follow up/duplication of what was changed in the following:

Unfortunately we fixed various misnamed testcases in ~~MDL-82431~~ after the above two issues were resolved, so we need to apply the same phpcs sniffs/fixes to those "new" tests

Note: phpcbf was used to automatically fix these

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83472- 404 to main.png
175 kB
23/Oct/24 10:13 AM
MDL-83472- 405 - main.png
82 kB
23/Oct/24 10:13 AM

blocks

MDL-83468 Bump to PHPUnit 11

Closed

duplicates

MDL-81522 Add void return type to standard unit tests

Closed

MDL-81523 setUp/tearDown/setUpBeforeClass/tearDownAfterClass should call parent methods

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Andrew Lyons

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, CiBoT, Jun Pataleta, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 16/Oct/24 8:00 PM

Updated:: 25/Oct/24 10:33 AM

Resolved:: 25/Oct/24 10:33 AM

Estimated:

Remaining:

Logged:

1d 2m

Details

Setup

main & 405 branches

main, 405 & 404 branches

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify