Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81459

Converted callbacks to hooks missing legacy calls

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 4.4
    • 4.4
    • General
    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-81459-main
    • Hide

      This is not easy to test in any way (very time consuming for very minimal benefit).

      This is a developer eye-casting check:

      1. Open lib/outputrenderers.php in your editor
      2. For each of the calls to dispatch() a hook:
        1. Confirm that there is an accompanying call to process_legacy_callbacks
        2. Confirm that it comes before the hook is dispatched
      Show
      This is not easy to test in any way (very time consuming for very minimal benefit). This is a developer eye-casting check: Open lib/outputrenderers.php in your editor For each of the calls to dispatch() a hook: Confirm that there is an accompanying call to process_legacy_callbacks Confirm that it comes before the hook is dispatched

      As jaked has just pointed out to me, I've missed calling legacy callbacks for some of the new hooks I introduced in MDL-81144.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Jake Dallimore Jake Dallimore
            Huong Nguyen Huong Nguyen
            Huong Nguyen Huong Nguyen
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 31 minutes
                31m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.