Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80442

Incorrect type annotations on update_local_user_password

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 4.3 regressions, 4.3
    • Authentication
    • None
    • MOODLE_403_STABLE

      The type annotations on update_internal_user_password in lib/moodlelib.php do not allow for "null" to be passed in as password. This is appropriate in the case where the auth plugin never gets to handle the user's password - e.g. auth_oidc, which is broken by the addition of these type annotations.

      It appears that the behaviour where null is passed in is otherwise acceptable, although a lot of the logic could probably be short-circuited in this case.

       

            Unassigned Unassigned
            nwpotago Nick Phillips
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.