Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80064

Null Passwords No Longer Allowed for Auth Plugin User Creation?

XMLWordPrintable

    • 2
    • Team Hedgehog 2024 Sprint 2.3, Team Hedgehog 2024 Review 2

      An August 24 change to `lib/moodlelib.php` has broken functionality for several auth plugins, namely that a user can no longer be created with a null password.  This was the behavior for both Microsoft's OAuth plugin and the ADL Initiative's JWT plugin, neither of which are currently working without either changing the Moodle codebase or creating a dummy password on their behalf.

      https://github.com/moodle/moodle/commit/07af783b9a9cff38d54192ea0b91175c9679d35e#diff-eb2182360f278d0c6d57c0a31237e3d1288024df1c21dd32609a731916ece2eeR4699

      The notion of a null password made perfect sense for these plugins, as the user does not have a conventional password, nor should they be permitted to guess a randomly generated one through the default login mechanism.  This also raises the possibility of pipeline tools flagging an auth plugin due to a password property being set explicitly.

      The current approach is to simply use the placeholder password and disallow all users from accessing the site through the manual flow.

      My main concern is that this change did not seem to be documented anywhere in the change / upgrade logs from our previous version 4.2 to the current 4.3.  As this is quite literally a breaking change, I would like to see it mentioned somewhere so that other teams can prepare accordingly when planning their updates.

      Thanks,
      -Trey

            meirza.arson@moodle.com Meirza
            vbhayden vbhayden
            Paul Holden Paul Holden
            Huong Nguyen Huong Nguyen
            CiBoT CiBoT
            Votes:
            2 Vote for this issue
            Watchers:
            14 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 1 hour, 33 minutes
                1d 1h 33m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.