Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73212

Disable skipped tests reporting in GHA

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11.8, 4.0.2
    • 3.11.4, 3.11.7, 4.0.1
    • Unit tests
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • Hide
      1. ^^^ Look to the GHA jobs in this issue, clicking on the "Core passing" badges that are show above of the testing instructions, on the right of the "Pull Master Branch field"
      2. Click on the "PHPUnit (ubuntu-20.04, 7.3, mysqli)" link.
        1. Expand the "Running PHPUnit tests" section.
        2. Verify that you see the text: Run vendor/bin/phpunit $phpunit_options
        3. Verify that, at the end of the PHPUnit execution you see the text: OK, but incomplete, skipped, or risky tests!
        4. Verify that there isn't any list of skipped tests anymore.
      3. Click on the "PHPUnit (ubuntu-20.04, 8, pgsql, xmlrpc-beta)" link.
        1. Expand the "Running PHPUnit tests" section.
        2. Verify that you see the text: Run vendor/bin/phpunit $phpunit_options
        3. Verify that, at the end of the PHPUnit execution you see the text: OK, but incomplete, skipped, or risky tests!
        4. Verify that there isn't any list of skipped tests anymore.

      That's all. Ciao

      Show
      ^^^ Look to the GHA jobs in this issue, clicking on the "Core passing" badges that are show above of the testing instructions, on the right of the "Pull Master Branch field" Click on the "PHPUnit (ubuntu-20.04, 7.3, mysqli)" link. Expand the "Running PHPUnit tests" section. Verify that you see the text: Run vendor/bin/phpunit $phpunit_options Verify that, at the end of the PHPUnit execution you see the text: OK, but incomplete, skipped, or risky tests! Verify that there isn't any list of skipped tests anymore. Click on the "PHPUnit (ubuntu-20.04, 8, pgsql, xmlrpc-beta)" link. Expand the "Running PHPUnit tests" section. Verify that you see the text: Run vendor/bin/phpunit $phpunit_options Verify that, at the end of the PHPUnit execution you see the text: OK, but incomplete, skipped, or risky tests! Verify that there isn't any list of skipped tests anymore. That's all. Ciao

      With the current configuration, skipped tests are logged in GHA and they can give the impression that they caused the failure.

        1. MDL-73212_master.webm
          3.41 MB
        2. MDL-73212_v311.webm
          3.93 MB
        3. MDL-73212_v400.webm
          3.29 MB

            stronk7 Eloy Lafuente (stronk7)
            noeldemartin Noel De Martin
            Paul Holden Paul Holden
            Jun Pataleta Jun Pataleta
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours
                3h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.