Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61770

GeoIP has moved (again)

XMLWordPrintable

      IPV6 lookup has started failing:

      1) core_iplookup_geoip_testcase::test_ipv6
      		 
      Coordinates are out of accepted tolerance
      		 
      Failed asserting that -118.4362 matches expected -118.2987.
      		 
       
      		 
      /var/www/html/iplookup/tests/geoip_test.php:104
      		 
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:80

      I'm tempted to suggest that we should switch our unit tests away from being an exact match to just a type:

      • City should be a string,
      • Country should be a string
      • Both parts of the title should be a string
      • Latitude should be a float
      • Longitude should be a float

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Jun Pataleta Jun Pataleta
            Jake Dallimore Jake Dallimore
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.