Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61455

Active pagination page floats above the participants filter suggestions list plus autocomplete element returning the promise

XMLWordPrintable

    • MOODLE_33_STABLE
    • MOODLE_33_STABLE
    • Hide

      Please test on 3.3 only, other branches were not modified in this issue.

      Test 1:

      1. Go into a course with over 100 participants (use "Generate test course" if needed)
      2. Open "Participants" page
      3. Inspect the anchor highlighted page 1 in the pagination bar and make sure the z-index does not apply

      Test 2:

      1. Create an assignment (in the same course)
      2. Click "Grade"
      3. Search for students in the quick search element on the top right, make sure it works normally
      Show
      Please test on 3.3 only, other branches were not modified in this issue. Test 1: Go into a course with over 100 participants (use "Generate test course" if needed) Open "Participants" page Inspect the anchor highlighted page 1 in the pagination bar and make sure the z-index does not apply Test 2: Create an assignment (in the same course) Click "Grade" Search for students in the quick search element on the top right, make sure it works normally

      For GDPR onboarding we are implementing the similar "smart" filter as what was introduced in MDL-59290 . There are couple of things introcuded in 3.4 that are missing in 3.3 and, therefore, makes it inconsistent for our plugin

      MDL-59809 lowered z-index of pagination - we need it in 3.3 as well.
      MDL-59368 changed form-autocomplete.enhance() method to return the promise - we need this change to allow the same code run on 3.3 and 3.4

        1. zindex.png
          78 kB
          Eloy Lafuente (stronk7)
        2. assign.png
          85 kB
          Eloy Lafuente (stronk7)

            marina Marina Glancy
            marina Marina Glancy
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Andrew Lyons Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.