Loading...

XML

Word

Printable

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Main Branch:
~~MDL-50766~~_master
Pull Main Diff URL:
https://github.com/dmonllao/moodle/compare/MDL-50766_master~...MDL-50766_master
Testing Instructions:
Hide

Run grunt from admin/tool/monitor

It SHOULD work and finish as expected (runs shifter for all tool_monitor YUI modules)

Run grunt from admin/tool/templatelibrary

It SHOULD work and finish as expected (there are no YUI modules, so it should display No YUI modules to build)

Run grunt from root

It SHOULD work and finish as expected (runs shifter once building all moodle YUI modules)
Show
Run grunt from admin/tool/monitor It SHOULD work and finish as expected (runs shifter for all tool_monitor YUI modules) Run grunt from admin/tool/templatelibrary It SHOULD work and finish as expected (there are no YUI modules, so it should display No YUI modules to build ) Run grunt from root It SHOULD work and finish as expected (runs shifter once building all moodle YUI modules)

The grunt script will fail to build AMD modules if there are no YUI modules present in the subdirectories below where grunt is called from.

To reproduce:

cd admin/tool
grunt

cd admin/tool/templatelibrary
grunt

result: shifter complains 'no modules found' and returns error code 1, amd build process never starts

Workaround:
cd admin/tool/templatelibrary/amd
grunt

caused a regression

MDL-53059 Grunt fails to build YUI modules when in a yui subdirectory, builds AMD instead

Participants:: cameron1729, CiBoT, David Monllaó, Davo Smith, Eloy Lafuente (stronk7), John Okely, Marina Glancy