Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Main Branch:
~~MDL-42401~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/90eb4ddd9a2285ebc60194c687f107200ad3e3d3...MDL-42401-master
Testing Instructions:
Hide

Open the edit pdf window

Verify it does opens near the top of the page

Verify you can drag the titlebar to move the window

Move the window around a bit

Use some drawing tools and verify that the annotations are drawn in the correct place.
Show
Open the edit pdf window Verify it does opens near the top of the page Verify you can drag the titlebar to move the window Move the window around a bit Use some drawing tools and verify that the annotations are drawn in the correct place.

My instinct when the popup appeared was to drag it in a better position.

I see the reason for that as 2 reasons:

The pdf was 1/4 of the way down my screen, and it didn't all fit on the screen, so i wanted to move it higher
Those JS dialogues all have a 'bar' at the top, which instinctively makes me drag it. As we discussed in the office, it might be clearer if the drag bar was different on non-draggable dialogues

Discovered while testing

MDL-42593 Increase zlib from recommended to required.

Testing discovered

MDL-42029 Editpdf: Page selector should indicate what page you are on

Participants:: Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Jason Fowler, Sam Hemelryk