Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38051

Annihilate all the CRLFs present in some question/fixtures...

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.3.5, 2.4.2
    • 2.3.4, 2.4.1
    • Questions
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • Hide

      1) Verify the patch only contains whitespace changes at EOL.

      git diff git diff --ignore-space-at-eol

      2) Verify all question tests pass.

      3) Verify that, once integrated, the CI servers are right now passing the "illegal whitespace" jobs.

      Show
      1) Verify the patch only contains whitespace changes at EOL. git diff git diff --ignore-space-at-eol 2) Verify all question tests pass. 3) Verify that, once integrated, the CI servers are right now passing the "illegal whitespace" jobs.

      Ignited by CONTRIB-4158 and detected by MDL-38040, it was detected that some question/fixtures do contain CRLFs and can be safely transformed to proper LFs.

      (See https://tracker.moodle.org/browse/CONTRIB-4158?focusedCommentId=203237&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-203237 for more info)

      The offending files are under:

      +question/format/blackboard/tests/fixtures/
      +question/format/blackboard_six/tests/fixtures/
      +question/format/xml/tests/fixtures/

      So this issue is about to:

      1) Take rid of all those CRLFs by changing them to LFs.
      2) In the CI servers take those directories out from quarantine.

            jmvedrine Jean-Michel Vedrine
            stronk7 Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.