Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38040

Detect all CRLFs in core and clean them

XMLWordPrintable

    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • Hide
      • Verify that only changes @ EOL have been introduced by the patch:

      git diff --ignore-space-at-eol  commitid
      

      • verify whitespace jobs are back to green in CI servers.
      Show
      Verify that only changes @ EOL have been introduced by the patch: git diff --ignore-space-at-eol commitid verify whitespace jobs are back to green in CI servers.

      While looking for information @ CONTRIB-4158, with some quick greps it was detected that we have a few CRLF terminations in core (ignoring imported libs, of course).

      This is about:

      1) Make the illegal_whitespace job to detect such CRLFs.
      2) Fix all the core ones.

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.