Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36316

Eliminate user-agent sniffing where possible

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.6
    • 2.4
    • Libraries
    • MOODLE_24_STABLE
    • MOODLE_26_STABLE
    • MDL-36316-master
    • Hide
      1. Exploritory test Moodle in IE
      2. Try downloading files in IE and firefox
      3. Enable the gradebook fixed students report and test it in all browsers
      4. Enable and try tinymce on all browsers.

      (Note that bugs from use of these will probably not be frm this issue, so we will need to compare against before the patch)

      Show
      Exploritory test Moodle in IE Try downloading files in IE and firefox Enable the gradebook fixed students report and test it in all browsers Enable and try tinymce on all browsers. (Note that bugs from use of these will probably not be frm this issue, so we will need to compare against before the patch)

      Its generally regarded as bad practice to do user-agent sniffing to control features. Problems with ua-sniffing were aptly demonstrated in MDL-35469, where features stopped working in latest version of firefox due to bad ua-sniffing.

      Most of the UA sniffing across moodle seems to be detecting really old browsers which are unsupported by Moodle, these could be eliminated.

      For JS, we should be doing feature detection (see http://modernizr.com/ etc).

      There will be some exceptions which we can't get rid of, but there is a lot of legacy rubbish we should be tidying up.

        1.
        		 Activity completion report should use feature detection rather than browser sniffing Sub-task Closed Dan Poltawski
        2.
        		 Investigate send_file() browser sniffing Sub-task Closed Unassigned
        3.
        		 Course format supports_ajax() no longer supports the property testedbrowsers Sub-task Closed Andrew Lyons
        4.
        		 Remove IE browser sniffing in admin/cron.php Sub-task Closed Dan Poltawski
        5.
        		 Bootstrap using non-standard browser sniffing Sub-task Closed Dan Poltawski

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Frédéric Massart Frédéric Massart
            Sam Hemelryk Sam Hemelryk
            Mark Nelson Mark Nelson
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.