Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36316 Eliminate user-agent sniffing where possible
  3. MDL-39964

Activity completion report should use feature detection rather than browser sniffing

XMLWordPrintable

    • MOODLE_26_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • MDL-39964-master
    • Hide

      In as many browsers as possible (at least IE>9, IE8, firefox, chrome, mobilesafari)

      1. Enable completion tracking in advanced features
      2. In a course, enable completion tracking in the course settings
      3. An activity to the course
      4. Go to course -> reports > activity completion
      5. VERIFY: no JS errors occur
      6. VERIFY: the text is rotated if the browser supports SVG (IE9+ and all the rest)
      7. VERIFY: the text is not rotated if the browser doesn't support SVG (IE8).
      Show
      In as many browsers as possible (at least IE>9, IE8, firefox, chrome, mobilesafari) Enable completion tracking in advanced features In a course, enable completion tracking in the course settings An activity to the course Go to course -> reports > activity completion VERIFY: no JS errors occur VERIFY: the text is rotated if the browser supports SVG (IE9+ and all the rest) VERIFY: the text is not rotated if the browser doesn't support SVG (IE8).

      Browser sniffing is problematic and should be avoiding. Since this feature uses JS to do its work, we should be able to use feature detection. Investigate nad implement.

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Sam Hemelryk Sam Hemelryk
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.