Loading...

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Main Branch:
wip-mdl-33379
Pull Main Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-33379
Testing Instructions:
Hide

Test 1

Make sure move_section() is not used in moodle core and is present in deprecatedlib.php

grep -Ri "move_section" .

Test 2

Log in as admin/teacher

Enable ajax and go to course

Turn editing on

Drag-n-Drop section below another section

Refresh page and make sure section retains it's position.

Drag-n-drop section to top

Turn editing off and refresh page

Make sure section retains it's position

Test 3

Repeat Test 2 with AJAX disabled and clicking up/down icons.
Show
Test 1 Make sure move_section() is not used in moodle core and is present in deprecatedlib.php grep -Ri "move_section" . Test 2 Log in as admin/teacher Enable ajax and go to course Turn editing on Drag-n-Drop section below another section Refresh page and make sure section retains it's position. Drag-n-drop section to top Turn editing off and refresh page Make sure section retains it's position Test 3 Repeat Test 2 with AJAX disabled and clicking up/down icons.

The move_section function was deprecated and now needs to be removed.

move_section and move_section_to are similar functions. It might be nice to remove move_section from course/lib.php

has been marked as being related by

MDL-33367 move_section function can lead to data corruption

Participants:: Ankit Agarwal, Dan Poltawski, Marina Glancy, Michael de Raadt, Rajesh Taneja, Sam Hemelryk