Loading...

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Main Branch:
wip-mdl-33367
Pull Main Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-33367
Testing Instructions:
Hide

Test 1:

run phpunit course/tests/courselib_test.php

Test 2:

Turn AJAX off for course

Move course up and down and make sure you can do it.

Test 3:

Turn AJAX on for course

Drag and move course up and down and make sure you can do it.
Show
Test 1: run phpunit course/tests/courselib_test.php Test 2: Turn AJAX off for course Move course up and down and make sure you can do it. Test 3: Turn AJAX on for course Drag and move course up and down and make sure you can do it.

move_section function is not using transaction and can lead to data corruption.
Also, it should use move_section_to, as it do similar work.

Discovered while testing

MDL-33546 Current week not updating after section drag-and-drop

has a non-specific relationship to

MDL-33379 Remove deprecated move_section in course/lib.php

has been marked as being related by

MDL-33347 Sections can't be moved when ajax is turned off

Participants:: Dan Poltawski, Eloy Lafuente (stronk7), Michael de Raadt, Rajesh Taneja, Sam Hemelryk, Sam Marshall