Description of the issue
---------------------------------------------------------------------------------
Teachers cannot see (or join) group activities if they are not enrolled in the group.

The module currently gets around this by assigning the editingteacher role to the activity creator in the course context and adding them to all of the site's groups.

There are two issues with this:
1. If one teacher creates the activity, and another teacher tries to access it they will get a "you must be enrolled in a group" error message (as only the activity creator is added to the site's groups). This is not standard Moodle behaviour.
2. The person setting up the activity might not be a teacher, but a Moodle administrator or a school administrator (and this might be a hidden role assignment). By creating this activity, they will be given an 'editing teacher role' (not a hidden role assignment) so these administrators will show up in the participants list as a teacher to students enrolled in the course.
3. Course groups are primarily for organising students. Having lecturers and administrators being enrolled in all of the groups makes this job more difficult, and potentially confusing if, for example, moodle admins turn up in teachers' group lists.

Expected Behaviour
---------------------------------------------------------------------------------
All teachers should be able to see and join all Adobe Connect group activities without being assigned the 'editinggteacher' role (as a visible assignment) or added to all of the course's group sites

Resolution
---------------------------------------------------------------------------------
1. a. CONTRIB-3367 makes sure that teachers (and any other roles with the 'moodle/site:accessallgroups' capability) can see all group meetings without being actually in the groups
1. b. The patch attached to this issue makes sure that teachers (and any other roles with the 'moodle/site:accessallgroups' capability) can access all group meetings (with whatever AC role they have been assigned) without being actually in the groups
2. Do not assign the activity creator the 'editingteacher' role (no longer necessary)
3. Do not add the activity creator to all site groups (no longer necessary)

Notes
---------------------------------------------------------------------------------
I have attached a document (AdobeConnect_groups_rethink.pdf) which explains what I think the expected behaviour for the Adobe Connect Module is in terms of:
1. Visibility of Adobe Connect meetings (as defined by Moodle core's group selector for activities: )
2. Ability to join meeting

Patch and github repo
---------------------------------------------------------------------------------
Links to be provided in comments section once I get a tracker number for this issue