Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3109

Add TS types to the return of WS functions of some addons

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.8.0
    • 3.7.1
    • Others
    • Hide

      This issue only needs to be tested in 1 device.

      IMO this issue doesn't need any exhaustive testing because it will be done during the pre-release testing.

      1. Navigate a bit in the app and check that nothing is broken. The features affected by this issue are: badges, timeline (dashboard block), blog, calendar, competencies, course completion, private files, messages, notes, notifications, book, chat, choice, folder, imscp, label, lti, page, resource, survey, url.
        • Like I said above, there's no need to test everything, that will be done in the pre-release testing.
      2. In a master or 3.7 site in web, create a badge with alignment/competencies and award it to a user.
      3. In the app, login with that user and open the badge. Check that you can view the alignment.
      Show
      This issue only needs to be tested in 1 device. IMO this issue doesn't need any exhaustive testing because it will be done during the pre-release testing. Navigate a bit in the app and check that nothing is broken. The features affected by this issue are: badges, timeline (dashboard block), blog, calendar, competencies, course completion, private files, messages, notes, notifications, book, chat, choice, folder, imscp, label, lti, page, resource, survey, url. Like I said above, there's no need to test everything, that will be done in the pre-release testing. In a master or 3.7 site in web, create a badge with alignment/competencies and award it to a user. In the app, login with that user and open the badge. Check that you can view the alignment.
    • MOODLE_37_STABLE
    • MOODLE_38_STABLE
    • Moodle App 3.8.0

      Right now, in WS calls we usually return any or any[]. We should type this returns to prevent errors like typos or using a wrong type.

      Changing this means a lot of code, so in this issue it will only be applied to some addons. I've opened issues to do the same with the rest of addons and with core too.

        1. MOBILE-3109-error-1.jpg
          MOBILE-3109-error-1.jpg
          90 kB

            dpalou Dani Palou
            dpalou Dani Palou
            Pau Ferrer Pau Ferrer
            Juan Leyva Juan Leyva
            Noel De Martin Noel De Martin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.