As the CI is currently ignoring files or parts of files that have not been changed, we hit a lot of PHP CS or PHP Doc issues when moving old code to another file like the deprecatedlib.php file as per the deprecation process.

I would like to check what would be the best approach for this:

• Ignoring completely the deprecatedlib.php in the checks
• Adding manually the phpcsignore or similar for phpdoc (I am not sure how we would really do it for phpdoc as there seems not to be an easy way to do it)

An example here:

https://integration.moodle.org/job/Precheck%20remote%20branch/135315/artifact/work/smurf.html#phpcs

Voting

Voting options

The following options are suggested for voting:

Voting options

Option A

Force developers to either fix the issue or use the phpcsignore in the deprecatedlib.php so to avoid the code checker to raise unwanted warnings.

Option B

Ignore all codechecks and phpdoc checks in the deprecatedlib.php from now on. It implies modifying our code checker to flag this as a file that can be ignored.