Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-5171

verify_commit_messages false positive counting "parents"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Low Low
    • Integration
    • None

      Happened @ MDL-59443

      git cat-file -p 83f662e0c7 | grep '^parent ' | tee >(cat 1>&2) | wc -l
      		 
       
      		 
      parent 5a651b43fb3d410d4b679c399c53eb023c29c182
      		 
      parent class. But I wanted to avoid modification of that third party
      		 
      2

      We just count ^parent occurrences in the commit.. and this time there was an "intruder" there leading to a wrong count. Try to make the check stronger (@ verify_commit_messages).

      Ciao

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.