Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-4192

Don't allow the phplint issue to pass until a broken file is made to pass again

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: High High
    • Integration
    • None

      The phplint job operates on files affected by a diff. That means that a push following it can continue to be failing the lint check but mark as passing because it compares against different files, you can see that here:

      http://ci.stronk7.com/job/08.%20Run%20PHP%20lint%20for%20affected%20files%20(master)/

      We should prevent that from happening.

      Some ideas:

      • Full lint on every push (-1, is too slow)
      • Store the last 'ok' git hash and do a diff against that when it fails?
      • Some jenkins feature which might help?
      • Enforce fulle codebase lints after a fail?

            Unassigned Unassigned
            poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.