Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8653

Langimport makes bad assumption about http headers

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 1.8
    • 1.8
    • Administration
    • None
    • MOODLE_18_STABLE
    • MOODLE_18_STABLE

      The language import function makes a bad assumption about http headers when going through a proxy only being 12 lines long, when in reality they could be longer or shorter...

      In my case I discovered this as it imported a blank line as an available language, but it could perhaps interpret a http header line as a language in a different scenario.

      My solution is to scan through the file until you find a CRLF, as per RFC1945, rather than just counting to 12.

      This guarantees we're at the start of the body (assuming a standards compliant webserver )

            pj Jon Papaioannou (Inactive)
            poltawski Dan Poltawski
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.