Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-85703

Adding a new LTI Advantage tool is not working in development environment

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 4.5.6
    • LTI External tool
    • None
    • MOODLE_405_STABLE

      An unsafe way to check if a property is defined is breaking the code, in production environments usually this issues are ignored to keep the site running but in development they typically throw an error and break the site.

      The issue is happening in this line https://github.com/moodle/moodle/blob/MOODLE_405_STABLE/mod/lti/openid-registration.php#L55 and is very straight forward to fix, it only needs to wrap the property inside an "isset()", example:

      if (isset($type->id)) {

       

      How to reproduce the issue

      Go to Site administration > Plugin > Activity modules > External tool > Manage tools

      Add a valid URL and click "Add LTI Advantage", an error should be displayed in an iframe.

       

      Step by step docs for connecting Moodle to Modle through LTI https://docs.moodle.org/500/en/LTI_Moodle_to_Moodle

            Unassigned Unassigned
            tasio.bertomeu@moodle.com Tasio Bertomeu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 27 minutes
                1h 27m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.