-
Task
-
Resolution: Done
-
Minor
-
None
-
5.0
-
MOODLE_500_STABLE
-
MDL-85687-main -
-
Fails against automated checks. 
Checked
MDL-85687using repository: https://github.com/snake/moodle
main [branch: MDL-85687-main | CI Job]
- Error: The
MDL-85687-main branch at https://github.com/snake/moodle does not apply clean to origin/main - Error: Merge conflict(s) in file(s):
- Error: lib/db/upgrade.php
- Error: version.php
- Error: The
Built on: Fri Jun 6 04:25:38 UTC 2025
Fails against automated checks. Checked MDL-85687 using repository: https://github.com/snake/moodle main [branch: MDL-85687-main | CI Job ] Error: The MDL-85687 -main branch at https://github.com/snake/moodle does not apply clean to origin/main Error: Merge conflict(s) in file(s): Error: lib/db/upgrade.php Error: version.php Should these errors be fixed? Built on: Fri Jun 6 04:25:38 UTC 2025
-
1
Noticed a few things when testing the branch after a rebase (and after 84825 has landed):
- activity chooser features are failing inside mod_lti (addtool.feature), since we now need to enable the 'mod_lti:acitivitychooser' placement to see tools in the chooser.
- This can be solved by adding an behat step to configure placements
- mod/lti/tests/behat/addtool.feature also highlighted a few problems with the code landed in 84415:
- Attempting to update servicesalt during an instance update (we only set it once, at creation time, so it can be removed)
- The links being created/updated/deleted are, in fact, being associated with the incorrect thing: they need to link to itemid=cmid, contextid=id of the course module context. Right now they're incorrectly linking using lti->id, which is the instance id not the cmid. For reference, see the mod_lti upgrade code which creates links - this does it correctly and links to cmid+cm contextid.
- There are also core_ltix behat failures, but they can't be resolved until course tools + site admin is updated to use the new placement+placement_status architecture.
This issue will just address 1 and 2.
