Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5.4, 5.0
Component/s: Accessibility toolkit
Labels:
- external_confirmed
- triaged

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/szymonk1101/moodle.git
Pull 4.5 Branch:
MDL-85573-tool-brickfield-uninstall-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...szymonk1101:MDL-85573-tool-brickfield-uninstall-405?w=1
Pull 5.0 Branch:
MDL-85573-tool-brickfield-uninstall-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...szymonk1101:MDL-85573-tool-brickfield-uninstall-500?w=1
Pull Main Branch:
MDL-85573-tool-brickfield-uninstall
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...szymonk1101:MDL-85573-tool-brickfield-uninstall?w=1
Testing Instructions:
Hide

For users with access to the database (e.g., via phpMyAdmin):

Log in as an administrator.

In the Site administration panel, search for the setting enableaccessibilitytools.

Make sure the enableaccessibilitytools setting is enabled (value: true).

Go to Plugins > Plugins overview and uninstall the tool_brickfield plugin (if necessary, also uninstall the block_accessreview plugin).

The uninstallation should complete successfully without any errors.

In the database, check the mdl_config table for a record where the name field equals enableaccessibilitytools. This record should no longer exist.

Without access to the database:

Log in as an administrator.

In the Site administration panel, search for the setting enableaccessibilitytools.

Uncheck the enableaccessibilitytools setting (set its value to false).

Go to Plugins > Plugins overview and uninstall the tool_brickfield plugin (if necessary, also uninstall the block_accessreview plugin).

The uninstallation should complete successfully without any errors.

Reinstall the tool_brickfield plugin.

In the Site administration panel, search again for the setting enableaccessibilitytools.

Check whether the enableaccessibilitytools setting is enabled (value: true). If the value is false (disabled), something went wrong.
Show
For users with access to the database (e.g., via phpMyAdmin): Log in as an administrator. In the Site administration panel, search for the setting enableaccessibilitytools . Make sure the enableaccessibilitytools setting is enabled (value: true). Go to Plugins > Plugins overview and uninstall the tool_brickfield plugin (if necessary, also uninstall the block_accessreview plugin). The uninstallation should complete successfully without any errors. In the database, check the mdl_config table for a record where the name field equals enableaccessibilitytools . This record should no longer exist. Without access to the database: Log in as an administrator. In the Site administration panel, search for the setting enableaccessibilitytools . Uncheck the enableaccessibilitytools setting (set its value to false). Go to Plugins > Plugins overview and uninstall the tool_brickfield plugin (if necessary, also uninstall the block_accessreview plugin). The uninstallation should complete successfully without any errors. Reinstall the tool_brickfield plugin. In the Site administration panel, search again for the setting enableaccessibilitytools . Check whether the enableaccessibilitytools setting is enabled (value: true). If the value is false (disabled), something went wrong.
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-85573 using repository: https://github.com/szymonk1101/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85573-tool-brickfield-uninstall-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85573-tool-brickfield-uninstall-500 | CI Job]

main (0 errors / 1 warnings) [branch: MDL-85573-tool-brickfield-uninstall | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-85573-tool-brickfield-uninstall branch at https://github.com/szymonk1101/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Tue Jun 10 14:31:56 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85573 using repository: https://github.com/szymonk1101/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85573-tool-brickfield-uninstall-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85573-tool-brickfield-uninstall-500 | CI Job ] main (0 errors / 1 warnings) [branch: MDL-85573-tool-brickfield-uninstall | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-85573 -tool-brickfield-uninstall branch at https://github.com/szymonk1101/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Tue Jun 10 14:31:56 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85573-tool-brickfield-uninstall-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19641/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67149/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67150/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85573-tool-brickfield-uninstall-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19642/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67151/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67152/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85573-tool-brickfield-uninstall

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19643/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67153/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67154/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67155/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67156/ App tests (stable app version)

Built on: Tue Jun 10 16:30:44 UTC 2025
Show
Launching automatic jobs for branch MDL-85573 -tool-brickfield-uninstall-405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19641/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67149/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67150/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85573 -tool-brickfield-uninstall-500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19642/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67151/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67152/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85573 -tool-brickfield-uninstall https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19643/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67153/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67154/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67155/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67156/ App tests (stable app version) Built on: Tue Jun 10 16:30:44 UTC 2025

The file in admin/tool/brickfield/db/uninstall.php has invalid content - it should do the plugin uninstall in function xmldb_tool_brickfield_uninstall(), not when including the file.

Fix proposal

instead of:

defined('MOODLE_INTERNAL') || die;

// Remove the 'enableaccessibilitytools' configuration setting in case of reinstall.

unset_config('enableaccessibilitytools');

use this:

defined('MOODLE_INTERNAL') || die;

/**

 * Uninstall Brickfield tool.

 * @return true

*/

function xmldb_tool_brickfield_uninstall(): bool {

    // Remove the 'enableaccessibilitytools' configuration setting in case of reinstall.

    unset_config('enableaccessibilitytools');

    return true;

Note that this is a small bug only, nothing should include this file directly except uninstallation, that is likely why this was not discovered during testing.

Assignee:: Unassigned

Reporter:: Petr Skoda

Peer reviewer:: Paul Holden

Participants:: Kim Jared Lucas, Michael Hawkins, Paul Holden, Petr Skoda, Szymon Karolczuk

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 23/May/25 7:13 PM

Updated:: 11/Jun/25 12:30 AM

Details

Description

Attachments

Activity

People

Dates

Clockify