-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.5.5, 5.0, 5.1
-
MOODLE_405_STABLE, MOODLE_500_STABLE, MOODLE_501_STABLE
-
MDL-85407-45
-
MDL-85407-50
-
-
Code verified against automated checks. 
Checked MDL-85407 using repository: https://github.com/durenadev/moodle
MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85407-45 | CI Job]- MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85407-50 | CI Job]
- main (0 errors / 0 warnings) [branch: MDL-85407 | CI Job]
More information about this report
Built on: Thu May 8 09:28:30 UTC 2025
Code verified against automated checks. Checked MDL-85407 using repository: https://github.com/durenadev/moodle MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85407-45 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85407-50 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85407 | CI Job ] More information about this report Built on: Thu May 8 09:28:30 UTC 2025 -
In the mod_data module (Database activity), the output generated when listing entries (list view) does not properly close some <div> tags. As a result, the HTML structure ends up malformed, placing the <footer> element inside the #topofscroll container. This affects the layout in themes where the footer is expected to be rendered at full page width (e.g., on moodle.org), although it may not be visually noticeable in standard Moodle themes.
This issue likely stems from the data_print_preference_form() function, which outputs the filtering and sorting form at the top of the list view. It opens several <div> containers but fails to close them properly, leaving the HTML hierarchy broken.
Steps to reproduce:
- Enable Performance Info under Site administration > Development > Debugging.
- Create a new course.
- Add a Database activity.
- Add several entries to the database.
- Go to the List view of the activity.
- Observe the HTML structure using browser developer tools or by viewing page source.
In a correct scenario (e.g., when viewing a single entry), the DOM should look like this:
<div id="page"> <div id="topofscroll"></div> <footer>...</footer></div>
However, in the list view, it becomes:
<div id="page"> <div id="topofscroll"> <footer>...</footer> </div></div>
Impact:
- Breaks layout in themes with fixed or full-width footers.
- Affects readability and rendering on moodle.org and similar custom setups.
- Could lead to unexpected behavior with CSS or JavaScript targeting these containers.
