Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4.9, 4.5.5, 5.1, 6.0
Component/s: Administration
Labels:
- CatalystIT
- ci
- partner

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_501_STABLE, MOODLE_600_STABLE
Pull from Repository:
https://github.com/gbarat87/moodle
Pull 4.5 Branch:
MDL-85335-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...gbarat87:moodle:MDL-85335-405
Pull 5.0 Branch:
MDL-85335-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...gbarat87:moodle:MDL-85335-500
Pull Main Branch:
MDL-85335-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...gbarat87:moodle:MDL-85335-main
Testing Instructions:
Hide

1) Install any plugin containing subplugins ex: https://github.com/catalyst/moodle-local_datacleaner

git submodule add -b MOODLE_311_STABLE git@github.com:catalyst/moodle-local_datacleaner.git local/datacleaner

2) Add any setting on one of the subplugins ex: admin/settings.php?section=cleaner_email

3) Remove the plugin from the code source ex:

rm -rf local/datacleaner/

rm -rf .git/modules/local/datacleaner/

git rm --cached local/datacleaner/

4) Uninstall the plugin:

php admin/cli/uninstall_plugins.php --plugins=local_datacleaner --run

5) Confirm that the subplugin still exist in the config table:

php admin/cli/cfg.php --component=cleaner_email

6) Uninstall the subplugin "cleaner_email":

php admin/cli/uninstall_plugins.php --plugins=cleaner_email --run

7) Confirm you see the success message:

Uninstalling: email

-->cleaner_email

++ Success ++

8) Confirm that the subplugin doesn't exist in the config table anymore:

php admin/cli/cfg.php --component=cleaner_email
Show
1) Install any plugin containing subplugins ex: https://github.com/catalyst/moodle-local_datacleaner git submodule add -b MOODLE_311_STABLE git@github.com:catalyst/moodle-local_datacleaner.git local/datacleaner 2) Add any setting on one of the subplugins ex: admin/settings.php?section=cleaner_email 3) Remove the plugin from the code source ex: rm -rf local/datacleaner/ rm -rf .git/modules/local/datacleaner/ git rm --cached local/datacleaner/ 4) Uninstall the plugin: php admin/cli/uninstall_plugins.php --plugins=local_datacleaner --run 5) Confirm that the subplugin still exist in the config table: php admin/cli/cfg.php --component=cleaner_email 6) Uninstall the subplugin "cleaner_email": php admin/cli/uninstall_plugins.php --plugins=cleaner_email --run 7) Confirm you see the success message: Uninstalling: email -->cleaner_email ++ Success ++ 8) Confirm that the subplugin doesn't exist in the config table anymore: php admin/cli/cfg.php --component=cleaner_email
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-85335 using repository: https://github.com/gbarat87/moodle

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85335-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85335-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-85335-main | CI Job]

_{More information about this report}

Built on: Wed May 7 23:19:35 UTC 2025
Show
Code verified against automated checks. Checked MDL-85335 using repository: https://github.com/gbarat87/moodle MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85335-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85335-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85335-main | CI Job ] More information about this report Built on: Wed May 7 23:19:35 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85335-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19260/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65831/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65832/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85335-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19261/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65833/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65834/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85335-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19262/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65835/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65836/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65837/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65838/ App tests (stable app version)

Built on: Mon May 12 04:30:29 UTC 2025
Show
Launching automatic jobs for branch MDL-85335 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19260/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65831/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65832/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85335 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19261/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65833/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65834/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85335 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19262/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65835/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65836/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65837/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65838/ App tests (stable app version) Built on: Mon May 12 04:30:29 UTC 2025

When using the cli script uninstall_plugins.php We cannot remove any subplugins if the main plugins code has been removed before.

Steps to replicate:

Install any plugin containing subplugins ex: https://github.com/catalyst/moodle-local_datacleaner / git submodule add -b MOODLE_311_STABLE git@github.com:catalyst/moodle-local_datacleaner.git local/datacleaner
Add any setting on one of the subplugins ex: admin/settings.php?section=cleaner_email
Remove the plugin from the code source ex:

rm -rf local/datacleaner/

rm -rf .git/modules/local/datacleaner/

git rm --cached local/datacleaner/

Uninstall the plugin:

php admin/cli/uninstall_plugins.php --plugins=local_datacleaner --run

Verify that the subplugin still exist in the config table:

SELECT * FROM mdl_config_plugins WHERE plugin = 'cleaner_email';

Uninstall the subplugin "cleaner_email":

php admin/cli/uninstall_plugins.php --plugins=cleaner_email --run

Notice the error message:

Can not be uninstalled:     email

Assignee:: Guillaume BARAT

Reporter:: Guillaume BARAT

Peer reviewer:: Brendan Heywood

Participants:: Brendan Heywood, Guillaume BARAT, Luca Bösch

Votes:: 1 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 01/May/25 1:27 PM

Updated:: 12/May/25 12:30 PM

Details

Description

Attachments

Activity

People

Dates

Clockify