Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-85287

User tours: Highlight incorrect while scrolling with backdrop

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5.4
    • User Tours
    • MOODLE_405_STABLE
    • MDL-85287-m405
    • MDL-85287-m500
    • MDL-85287-main
    • Hide
      1. Go to the user tours page (Site administration > Appearance > User tours)
      2. Click Import button.
      3. Drag in the .json file that is attached to this issue, and press Save changes.
      4. Go to the General tab of Site administration.
      5. The Test tour should appear. Follow the instructions by making sure you can see the Badges link near the bottom of your window (if necessary resize the window). This is so that it will have to scroll to show the next step.
      6. Click Next, watching the Badges link carefully.
        • EXPECTED: The link should scroll up, and then the next step popup should appear next to it, and the link should be highlighted so that the rest of the page has a dark background.
        • EXPECTED: The link highlight (dark background for rest of page) does not appear until scrolling finishes.
      7. Continue through the rest of the tour, confirming that behaviour is as expected.

      (Note I set the tour to appear every time you load that page so you can just reload the page if you want to repeat the test.)

      Show
      Go to the user tours page (Site administration > Appearance > User tours) Click Import button. Drag in the .json file that is attached to this issue, and press Save changes . Go to the General tab of Site administration. The Test tour should appear. Follow the instructions by making sure you can see the Badges link near the bottom of your window (if necessary resize the window). This is so that it will have to scroll to show the next step. Click Next , watching the Badges link carefully. EXPECTED: The link should scroll up, and then the next step popup should appear next to it, and the link should be highlighted so that the rest of the page has a dark background. EXPECTED: The link highlight (dark background for rest of page) does not appear until scrolling finishes. Continue through the rest of the tour, confirming that behaviour is as expected. (Note I set the tour to appear every time you load that page so you can just reload the page if you want to repeat the test.)
    • Hide

      Code verified against automated checks.

      Checked MDL-85287 using repository: https://github.com/sammarshallou/moodle.git

      More information about this report

      Built on: Tue Apr 29 04:59:04 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-85287 using repository: https://github.com/sammarshallou/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85287-m405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85287-m500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85287-main | CI Job ] More information about this report Built on: Tue Apr 29 04:59:04 UTC 2025

      If you have a user tour step set to use the 'backdrop' feature so that the targeted area is being highlighted, and if the browser has to scroll to show the area, then the display is wrong. I think this was probably broken in MDL-83005.

      What happens is:

      • When the step starts, the white highlight area appears over the correct location (e.g the Timeline block in my demo video)
      • The browser scrolls up/down to the correct location, but during this scroll, the white highlight area does not move and it looks very strange
      • When scroll finishes, the highlight area is updated and now appears in the correct location.

      So the 'end' result is OK but the animation looks terrible. I made a - really bad - example video of this happening in the attached .mp4. If you are watching very carefully you can see that the Timeline block 'escapes' its highlight for a short time during the scroll.

        1. firefox_6vf7XcEREI.mp4
          242 kB
          Sam Marshall
        2. tour_export_7_1745829552.json
          2 kB
          Sam Marshall

            quen Sam Marshall
            quen Sam Marshall
            David Woloszyn David Woloszyn
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 8 minutes
                8m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.