Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.19, 4.4.9, 4.5.5, 5.0.1
Affects Version/s: 5.1
Component/s: Activity completion, Automated functional tests (behat), Resource
Labels:
- ci
- triaged

Affected Branches:
MOODLE_501_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/andelacruz/moodle.git
Pull 4.1 Branch:
~~MDL-85279~~-401
Pull 4.1 Diff URL:
https://github.com/andelacruz/moodle/compare/757f0a56c9...MDL-85279-401
Pull 4.4 Branch:
~~MDL-85279~~-404
Pull 4.4 Diff URL:
https://github.com/andelacruz/moodle/compare/7e75a3680e...MDL-85279-404
Pull 4.5 Branch:
~~MDL-85279~~-405
Pull 4.5 Diff URL:
https://github.com/andelacruz/moodle/compare/6dd1f61866...MDL-85279-405
Pull 5.0 Branch:
~~MDL-85279~~-500
Pull 5.0 Diff URL:
https://github.com/andelacruz/moodle/compare/6999197243...MDL-85279-500
Pull Main Branch:
~~MDL-85279~~-main
Pull Main Diff URL:
https://github.com/andelacruz/moodle/compare/9242f9619a...MDL-85279-main
Testing Instructions:

Hide

Automated tests will handle this.

Show
Automated tests will handle this.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-85279~~ using repository: https://github.com/andelacruz/moodle.git

MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-85279-401 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-85279-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85279-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85279-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-85279-main | CI Job]

_{More information about this report}

Built on: Wed May 14 07:32:16 UTC 2025
Show
Code verified against automated checks. Checked MDL-85279 using repository: https://github.com/andelacruz/moodle.git MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-85279-401 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-85279-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85279-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85279-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85279-main | CI Job ] More information about this report Built on: Wed May 14 07:32:16 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85279~~-401

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65992/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65993/ Behat (Firefox - boost / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65994/ Behat (Firefox - classic / --name "View activity completion information in the Page resource")

Launching automatic jobs for branch ~~MDL-85279~~-404

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65995/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65996/ Behat (Firefox - boost / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65997/ Behat (Firefox - classic / --name "View activity completion information in the Page resource")

Launching automatic jobs for branch ~~MDL-85279~~-405

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65998/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65999/ Behat (Firefox - boost / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66000/ Behat (Firefox - classic / --name "View activity completion information in the Page resource")

Launching automatic jobs for branch ~~MDL-85279~~-500

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66001/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66002/ Behat (Firefox - boost / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66003/ Behat (Firefox - classic / --name "View activity completion information in the Page resource")

Launching automatic jobs for branch ~~MDL-85279~~-main

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66004/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66005/ Behat (Firefox - boost / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66006/ Behat (Firefox - classic / --name "View activity completion information in the Page resource")

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66007/ App tests (stable app version) / --name "View activity completion information in the Page resource")

Built on: Tue May 13 08:02:37 UTC 2025
Show
Launching automatic jobs for branch MDL-85279 -401 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65992/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65993/ Behat (Firefox - boost / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65994/ Behat (Firefox - classic / --name "View activity completion information in the Page resource") Launching automatic jobs for branch MDL-85279 -404 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65995/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65996/ Behat (Firefox - boost / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65997/ Behat (Firefox - classic / --name "View activity completion information in the Page resource") Launching automatic jobs for branch MDL-85279 -405 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65998/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65999/ Behat (Firefox - boost / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66000/ Behat (Firefox - classic / --name "View activity completion information in the Page resource") Launching automatic jobs for branch MDL-85279 -500 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66001/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66002/ Behat (Firefox - boost / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66003/ Behat (Firefox - classic / --name "View activity completion information in the Page resource") Launching automatic jobs for branch MDL-85279 -main https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66004/ Behat (NonJS - boost and classic / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66005/ Behat (Firefox - boost / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66006/ Behat (Firefox - classic / --name "View activity completion information in the Page resource") https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66007/ App tests (stable app version) / --name "View activity completion information in the Page resource") Built on: Tue May 13 08:02:37 UTC 2025

On mod/page/tests/behat/page_activity_completion.feature

There are 2 scenarios that pass but they are completely wrong:

Scenario: The manual completion button will not be shown on the course page if the Show activity completion conditions is set to No as teacher
Scenario: The manual completion button will not be shown on the course page if the Show activity completion conditions is set to No as student

They use the Course 2 described on Background but the student and the teacher are not enrolled so they go to the enrolment page where logically the completion buttons don't exist.

Additionally they are navigating to the page activity and the test relates to course page, so they should navigate to course page where the buttons should not be there.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

85279 peer review - behat.png
08/May/25 5:26 PM
226 kB
Andrew Gosali

Assignee:: Angelia Dela Cruz

Reporter:: Pau Ferrer

Peer reviewer:: Andrew Gosali

Integrator:: Simey Lameze

Tester:: CiBoT

Participants:: Andrew Gosali, Angelia Dela Cruz, CiBoT, Huong Nguyen, Pau Ferrer, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 24/Apr/25 9:29 PM

Updated:: 16/May/25 1:43 PM

Resolved:: 16/May/25 1:43 PM

Estimated:

Remaining:

Logged:

3d 2h 51m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify