Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5.5
Component/s: Tasks
Labels:

Affected Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.5 Branch:
MDL-85262-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-85262-405
Pull 5.0 Branch:
MDL-85262-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-85262-500
Pull Main Branch:
MDL-85262
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-85262

Testing Instructions:

Hide

Setup

Temporarily disable cron

Insert the following records in your database:

INSERT INTO `moodle`.`m_task_adhoc` (`component`, `classname`, `nextruntime`, `timecreated`) VALUES ('mod_forum', '\\mod_forum\\task\\send_user_digests', 1735725600, 1735725600);

INSERT INTO `moodle`.`m_task_adhoc` (`component`, `classname`, `nextruntime`, `timecreated`) VALUES ('mod_forum', '\\mod_forum\\task\\send_user_digests', 1767261600, 1767261600);

Test

Log in as admin
Navigate to Server > Tasks > Ad hoc tasks in site administration
Press on send_user_digests
Confirm the first inserted {task_adhoc} record shows "Next run: ASAP"
Confirm the second inserted {task_adhoc} record shows "Next run: Thursday, 1 January 2026, 10:00 AM" (date in the future, actual time will depend on your local timezone)

NOTE: This is now also covered by Behat.

Show

Setup Temporarily disable cron Insert the following records in your database: INSERT INTO `moodle`.`m_task_adhoc` (`component`, `classname`, `nextruntime`, `timecreated`) VALUES ('mod_forum', '\\mod_forum\\task\\send_user_digests', 1735725600, 1735725600); INSERT INTO `moodle`.`m_task_adhoc` (`component`, `classname`, `nextruntime`, `timecreated`) VALUES ('mod_forum', '\\mod_forum\\task\\send_user_digests', 1767261600, 1767261600); Test Log in as admin Navigate to Server > Tasks > Ad hoc tasks in site administration Press on send_user_digests Confirm the first inserted { task_adhoc } record shows "Next run: ASAP" Confirm the second inserted { task_adhoc } record shows "Next run: Thursday, 1 January 2026, 10:00 AM" (date in the future, actual time will depend on your local timezone) NOTE : This is now also covered by Behat.

Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-85262 using repository: https://github.com/paulholden/moodle/

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85262-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85262-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-85262 | CI Job]

_{More information about this report}

Built on: Tue May 13 21:48:16 UTC 2025
Show
Code verified against automated checks. Checked MDL-85262 using repository: https://github.com/paulholden/moodle/ MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85262-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85262-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85262 | CI Job ] More information about this report Built on: Tue May 13 21:48:16 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85262-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19331/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66055/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66056/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85262-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19332/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66057/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66058/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85262

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19333/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66059/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66060/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66061/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66062/ App tests (stable app version)

Built on: Tue May 13 22:25:21 UTC 2025
Show
Launching automatic jobs for branch MDL-85262 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19331/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66055/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66056/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85262 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19332/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66057/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66058/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85262 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19333/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66059/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66060/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66061/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66062/ App tests (stable app version) Built on: Tue May 13 22:25:21 UTC 2025

While looking at the ad-hoc tasks report, I noticed that there were a lot of instances of the \mod_forum\task\send_user_digests task, which said the next one was due to run at 5pm today:

However, viewing the list of instances for this task, they all say they are due to run "ASAP":

I believe that this is because this condition in `tool_task_renderer` is backwards:

$nextrun = $due ? userdate($nextruntime) : get_string('asap', 'tool_task');

If the task is due, it displays the next runtime. If it's not due, it displays "ASAP", which is incorrect.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Screenshot from 2025-04-23 11-05-46.png
23/Apr/25 6:12 PM
12 kB
Mark Johnson
Screenshot from 2025-04-23 11-05-57.png
23/Apr/25 6:12 PM
47 kB
Mark Johnson

Assignee:: Paul Holden

Reporter:: Mark Johnson

Peer reviewer:: Daniel Ziegenberg

Participants:: CiBoT, Daniel Ziegenberg, Huong Nguyen, Mark Johnson, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 23/Apr/25 6:12 PM

Updated:: 13/Jun/25 4:05 PM

Details

Setup

Test

Description

Attachments

Attachments

Activity

People

Dates

Clockify